fix: TXT decode preserves string-boundary info#125
Open
msimerson wants to merge 1 commit into
Open
Conversation
msimerson
force-pushed
the
h6-txt-as-array
branch
from
a542e86 to
808d158
Compare
msimerson
force-pushed
the
h6-txt-as-array
branch
from
808d158 to
7c07f35
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC 1035 §3.3.14
A TXT RDATA can contain multiple
<character-string>items, each length-prefixed.Packet.Resource.TXT.decode(packet.js:618–633) concatenates all strings into a singlethis.datavalue, discarding the boundaries. Applications that rely on multi-string TXT records (SPF, DKIM) will receive incorrect data.The encoder handles arrays correctly; the asymmetry means decode→encode is lossy.
PS: it was back around node.js 0.11 or so when c-ares had this exact same issue, and had to resolve it this same way. It affected us over in Haraka, a SMTP daemon, where we consume a lot of SPF and DKIM records.