Skip to content

add tag with both attr and value#102

Open
Crazyokd wants to merge 1 commit into
manoelcampos:masterfrom
Crazyokd:master
Open

add tag with both attr and value#102
Crazyokd wants to merge 1 commit into
manoelcampos:masterfrom
Crazyokd:master

Conversation

@Crazyokd

@Crazyokd Crazyokd commented Sep 26, 2024

Copy link
Copy Markdown
Collaborator

implement #101

@materazu

Copy link
Copy Markdown
Collaborator

Can we merge that please, needed

@Crazyokd

Copy link
Copy Markdown
Collaborator Author

@materazu you can try my custom version.

@materazu

materazu commented Jan 17, 2025

Copy link
Copy Markdown
Collaborator

Thx a lot @Crazyokd, but on our company projet, we can only install via luarocks install standard command.
I worked around the issue by only using attributes with specific naming for the value, and with rebuild regex after text output, it works, it's clearly not clean but it works.

@Crazyokd

Copy link
Copy Markdown
Collaborator Author

Thx a lot @Crazyokd, but on our company projet, we can only install via luarocks install standard command. I worked around the issue by only using attributes with specific naming for the value, and with rebuild regex after text output, it works, it's clearly not clean but it works.

OK, I'll consider add support for luarocks as soon as possible.

@Crazyokd

Copy link
Copy Markdown
Collaborator Author

@materazu Now you can use my custom version by using luarocks. I hope you can really try it.

@manoelcampos

manoelcampos commented Jan 20, 2025

Copy link
Copy Markdown
Owner

@Crazyokd I’m looking for someone to maintain the project. If you are interested, I can even give you the ownership of the repo

@Crazyokd

Copy link
Copy Markdown
Collaborator Author

@Crazyokd I’m looking for someone to maintain the project. If you are interested, I can even give you the ownership of the repo

@manoelcampos I'm interested in it, but I might make a big design change.

@manoelcampos

manoelcampos commented Jan 21, 2025

Copy link
Copy Markdown
Owner

Feel free to change as you wish. I'm sending you an invite to join.

@materazu

Copy link
Copy Markdown
Collaborator

Hi guys, we need to improve many things in this project.
@manoelcampos send me an invite!

@manoelcampos

Copy link
Copy Markdown
Owner

Now you can use my custom version by using luarocks. I hope you can really try it.

@Crazyokd if you are interested, I’ll give you access to the repo, so that you can merge your changes here as you want.

@manoelcampos

manoelcampos commented Jun 12, 2025

Copy link
Copy Markdown
Owner

Hi guys, we need to improve many things in this project. @manoelcampos send me an invite!

I’ve just sent it

@iykon

iykon commented Oct 28, 2025

Copy link
Copy Markdown

Hey @materazu @Crazyokd what's the plan merging this commit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants