[Shopify] Rename 'Auto Create Catalog' to 'Auto Create B2B Catalog' caption and tooltip#8647
Open
onbuyuka wants to merge 2 commits into
Open
[Shopify] Rename 'Auto Create Catalog' to 'Auto Create B2B Catalog' caption and tooltip#8647onbuyuka wants to merge 2 commits into
onbuyuka wants to merge 2 commits into
Conversation
…aption and tooltip The generic 'Catalog' term is ambiguous now that both B2B catalogs and Market catalogs exist. Rename the field caption and tooltip on the Shop table to clarify that this setting creates a B2B catalog for new companies. Fixes AB#638864 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
… rename The test asserted the literal old caption 'Auto Create Catalog'. Renaming the field caption to 'Auto Create B2B Catalog' changes the plan-validation error text, so derive the expected error from Shop.FieldCaption to keep the assertion robust against caption changes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Now that both B2B catalogs and Market catalogs exist, the generic term
Catalogin the company-relatedAuto Create Catalogsetting is ambiguous. This renames the field caption and tooltip on the Shop table (table 30102Shpfy Shop, field 120) to clarify that the setting creates a B2B catalog for new companies.Auto Create Catalog->Auto Create B2B Catalog...whether a catalog is automatically created...->...whether a B2B catalog is automatically created...The AL field identifier is intentionally left unchanged (renaming it would be a breaking change). Translation
.g.xlffiles are generated at build time and gitignored, so they are not part of this diff.Fixes AB#638864