Skip to content

[releases/27.4] [Shopify] API 2026-01 uptake (#6244)#8659

Open
djukicmilica wants to merge 5 commits into
releases/27.4from
features/621974-shopify-api-2026-01-uptake-27.4
Open

[releases/27.4] [Shopify] API 2026-01 uptake (#6244)#8659
djukicmilica wants to merge 5 commits into
releases/27.4from
features/621974-shopify-api-2026-01-uptake-27.4

Conversation

@djukicmilica

@djukicmilica djukicmilica commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Backport of #6244 to releases/27.4 as part of slice 621974.

Fixes AB#617321

Commits included

SHA Source PR Description
307164b #4747, #6244, #7214, #8309 API 2026-01 uptake (squash cherry-pick from 27.x backport 17f676af4) — includes import unverified returns prerequisite, main API uptake, skip-empty-inventory fix, pagination cursor fix, id-range bump, AL0570 fix, and test alignment
2bd3f6c #8547 Fix codeunit 139593 ID clash (move to 134248)

Same set of changes as the 27.x backport (#8360) and the 27.5 backport (#8366).

Conflict resolution

The cherry-pick had 2 conflicts caused by PR #7633 (multi-store payout fix) being present on releases/27.x but absent on releases/27.4:

  • ShpfyPayout.Table.al: Accepted incoming fields 16 (External Trace Id) and 101 (Shop Code) — trivial, no actual conflict on 27.4.
  • ShpfyPaymentsTest.Codeunit.al: Accepted incoming new tests and helpers. Added Shop: Record "Shpfy Shop" global variable (present on 27.x from [Shopify] Fix payout and dispute sync skipping records in multi-store setups #7633 but absent on 27.4; required by the new Initialize() procedure and payout tests).

github-actions Bot and others added 2 commits June 18, 2026 00:36
Backport of #6244 to releases/27.4.
Cherry-picked from releases/27.x squash commit (17f676a).

Conflict resolution:
- ShpfyPayout.Table.al: accepted incoming fields 16/101 (no conflict on 27.4)
- ShpfyPaymentsTest: accepted incoming + added Shop global var (present on
  27.x from #7633 but absent on 27.4)
…8) (#8547)

Codeunit 139593 `"Shpfy Inventory Subscriber"` was reintroduced on the
release branch by the API 2026-01 uptake backport (PR #8360) but clashes
with the codeunit 139593 in the BCApps Shopify Connector Test 28.0.0.0
baseline, which is checked by BuildCop and the BC platform during NAV
gate validation (`VerifyApplicationChanges` failed in job 3581779, NAV
PR 248771).

## Fix

Renumber the codeunit from 139593 to **134248** and extend the existing
`134241-134247` `idRange` in `src/Apps/W1/Shopify/Test/app.json` to
`134248`.

134248 is confirmed free across:
- NAV source (`C:\depot\NAV2\App\Apps`, `Layers`, `Internal`, `Test`,
`Extension`)
- BCApps source on `main`, `releases/27.x`, and `releases/27.5`
- All 137 `.app` baselines in NAV2 (Shopify Test 25.8 through 29.0 and
every other app)

All other references to the codeunit use the name `"Shpfy Inventory
Subscriber"` rather than the ID, so no callers need to change.

Companion fix for releases/27.5: PR will follow with the same change.

Fixes
[AB#638064](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/638064)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@djukicmilica djukicmilica requested review from a team as code owners June 17, 2026 22:37
@github-actions github-actions Bot added the AL: Apps (W1) Add-on apps for W1 label Jun 17, 2026
@github-actions github-actions Bot added this to the Version 27.4 milestone Jun 17, 2026
dcenic
dcenic previously approved these changes Jun 18, 2026
Use a separate PaymentsAPI codeunit instance with no shop set for the
first import, ensuring Shop Code is truly blank. Also guard against
pre-existing payout records that could cause false failures.

@onbuyuka onbuyuka left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the reason for this backport? it is attached to a slice, meaning it will not trigger a hotfix pipeline.

@djukicmilica

Copy link
Copy Markdown
Contributor Author

what is the reason for this backport? it is attached to a slice, meaning it will not trigger a hotfix pipeline.

We have a tenant on 26.5 that cannot be upgraded due to a platform bug that they have been trying to fix since October 2025. We need to solve it till July 1. I am creating hotfixes for 26.5, 27.x, 27.0 .. 27.4

What do you suggest doing in order to trigger hotfixes?

@onbuyuka

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Stale Status Check Deleted

The Pull Request Build workflow run for this PR was older than 72 hours and has been deleted.

📋 Why was it deleted?

Status checks that are too old may no longer reflect the current state of the target branch. To ensure this PR is validated against the latest code and passes up-to-date checks, a fresh build is required.


🔄 How to trigger a new status check:

  1. 📤 Push a new commit to the PR branch, or
  2. 🔁 Close and reopen the PR

This will automatically trigger a new Pull Request Build workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AL: Apps (W1) Add-on apps for W1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants