[Shopify] Fix AL0132: expose ImportPayout as internal for test access#8685
Closed
Copilot wants to merge 5 commits into
Closed
[Shopify] Fix AL0132: expose ImportPayout as internal for test access#8685Copilot wants to merge 5 commits into
Copilot wants to merge 5 commits into
Conversation
…8) (#8548) Codeunit 139593 `"Shpfy Inventory Subscriber"` was reintroduced on the release branch by the API 2026-01 uptake backport (PR #8366) but clashes with the codeunit 139593 in the BCApps Shopify Connector Test 28.0.0.0 baseline, which is checked by BuildCop and the BC platform during NAV gate validation (`VerifyApplicationChanges` failed in job 3581772, NAV PR 248762). ## Fix Renumber the codeunit from 139593 to **134248** and extend the existing `134241-134247` `idRange` in `src/Apps/W1/Shopify/Test/app.json` to `134248`. 134248 is confirmed free across: - NAV source (`C:\depot\NAV2\App\Apps`, `Layers`, `Internal`, `Test`, `Extension`) - BCApps source on `main`, `releases/27.x`, and `releases/27.5` - All 137 `.app` baselines in NAV2 (Shopify Test 25.8 through 29.0 and every other app) All other references to the codeunit use the name `"Shpfy Inventory Subscriber"` rather than the ID, so no callers need to change. Companion fix for releases/27.x: #8547. Fixes [AB#638060](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/638060) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…to allow test access The test UnitTestImportPayoutWithExternalTraceId in ShpfyPaymentsTest.Codeunit.al calls PaymentsAPI.ImportPayout(JPayout), but ImportPayout was declared as `local procedure`, which is not accessible outside the codeunit even via internalsVisibleTo. Fix: Change `local procedure ImportPayout` to `internal procedure ImportPayout` in ShpfyPaymentsAPI.Codeunit.al so the test can call it (the Shopify Connector app already declares internalsVisibleTo for the Shopify Connector Test app). Also merges the PR #8683 API 2026-01 uptake changes (External Trace Id field, new test, and other API changes) into the branch.
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job for Build Apps
[Shopify] Fix AL0132: expose ImportPayout as internal for test access
Jun 19, 2026
github-actions
Bot
added
the
needs-approval
djukicmilica
approved these changes
Jun 21, 2026
github-actions
Bot
removed
the
needs-approval
Contributor
|
I am closing this one as we have another one that has changes from this PR + BB fixes |
auto-merge was automatically disabled
June 21, 2026 11:45
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #8683 added
UnitTestImportPayoutWithExternalTraceIdwhich callsPaymentsAPI.ImportPayout()directly, butImportPayoutwas declaredlocal— inaccessible even viainternalsVisibleTo, causing AL0132 at compile time on the Shopify Connector Test app.Changes
ShpfyPaymentsAPI.Codeunit.al: ChangedImportPayoutfromlocaltointernal, making it accessible from the test app (which already hasinternalsVisibleToaccess)Also includes the full API 2026-01 uptake backport (PR #8683):
External Trace Idfield onShpfy Payout, inventory API idempotency/retry logic, unverified return lines, article reference metafield support, Tax Code deprecation stubs, and codeunit ID clash fix (139593 → 134248).Related work items: AB#617321, AB#637744