[Subcontracting] Removing dead code from subcontracting.#8712
Draft
6CRIPT wants to merge 3 commits into
Draft
Conversation
…rs (bug 638466)
The 'Source Subtype' field (99001535) on Transfer Header, Transfer Shipment
Header and Transfer Receipt Header was only ever written/filtered with value
'2' (Vendor), making the Customer ('1') and Item ('3') branches of
HandleSubcontractingSourceLookup dead code and the field itself redundant
with 'Subc. Source Type' = Subcontracting.
Removes the field, drops it from key Key99001501, simplifies the lookup to
Vendor-only, and removes all writes/filters/copies/page controls referencing
it. Mirrors the fix for Direct Trans. Header (bug 617373). Adds a regression
test verifying Source Type and Source ID still propagate to the posted
Transfer Shipment Header.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as low quality.
This comment was marked as low quality.
This comment was marked as low quality.
This comment was marked as low quality.
This comment was marked as low quality.
This comment was marked as low quality.
This comment was marked as low quality.
This comment was marked as low quality.
…eation reports (PR 8712 review) Make the duplicate-check queries in Subc. Create Transf. Order and Subc. Create SubCReturnOrder explicitly filter on 'Subc. Source Type' = Subcontracting after removing the redundant 'Source Subtype' filter. The queries were already scoped to subcontracting records (via 'Subcontr. Purch. Order No.' / 'Subc. Return Order'), but the explicit filter documents intent, aligns with Subc. Synchronize Management and lets the query use key Key99001501.
…Header (PR 8712 review) The regression test only asserted source-field propagation on the Transfer Shipment Header, leaving the parallel change in Subc. Trans Rcpt Header Ext uncovered. Post the inbound receipt leg as well and assert that 'Subc. Source Type' and 'Source ID' are propagated to the Transfer Receipt Header. Renamed the test to reflect that it now covers both posted headers.
Contributor
Field removed without obsolete deprecation lifecycleField Recommendation:
Line mapping was unavailable, so this was posted as an issue comment. 👍 useful · ❤️ especially valuable · 👎 wrong - reply with why |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes AB#638466