Skip to content

fix: infra changes for Code mod #453

Closed
Ashwal-Microsoft wants to merge 17 commits into
devfrom
infra-conproc-Ash
Closed

fix: infra changes for Code mod #453
Ashwal-Microsoft wants to merge 17 commits into
devfrom
infra-conproc-Ash

Conversation

@Ashwal-Microsoft

Copy link
Copy Markdown

This pull request introduces a major reorganization and enhancement of the infrastructure code to support a flavor-based structure, improve modularity, and align with Azure Verified Modules (AVM) standards. It also updates deployment workflows and documentation to reflect these changes. The most important changes are summarized below.

Infrastructure Structure & Modularity

  • The infra folder now uses a flavor-based structure with separate directories for AVM-oriented (infra/avm), vanilla Bicep (infra/bicep), and shared core modules (infra/modules). Shared modules are to remain unchanged for GSA customization, with changes applied in flavor-specific entry files. [1] [2] [3]
  • Added several AVM-compliant placeholder modules under infra/avm/modules (e.g., ai-foundry-connection.bicep, app-service.bicep, etc.) and implemented detailed AVM modules for compute resources like container-app.bicep, container-app-environment.bicep, and container-instance.bicep. [1] [2] [3] [4]

Deployment & Parameterization Enhancements

  • Deployment workflows and configuration files (.github/workflows/deploy.yml, azure.yaml, azure_custom.yaml) are updated to support a deploymentFlavor parameter and to align with the new infra structure. This enables selection of deployment paths (e.g., bicep, avm, avm-waf) and centralizes parameter files. [1] [2] [3]

Documentation Updates

  • The deployment guide and README have been updated to explain the new infra structure, flavor selection, core module governance, and the standardized scripts layout under infra/scripts (including build, pre/post-provision, and utilities). [1] [2]

References:

  • ...

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants