fix: infra changes for Code mod #453
Closed
Ashwal-Microsoft wants to merge 17 commits into
Closed
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a major reorganization and enhancement of the infrastructure code to support a flavor-based structure, improve modularity, and align with Azure Verified Modules (AVM) standards. It also updates deployment workflows and documentation to reflect these changes. The most important changes are summarized below.
Infrastructure Structure & Modularity
infrafolder now uses a flavor-based structure with separate directories for AVM-oriented (infra/avm), vanilla Bicep (infra/bicep), and shared core modules (infra/modules). Shared modules are to remain unchanged for GSA customization, with changes applied in flavor-specific entry files. [1] [2] [3]infra/avm/modules(e.g.,ai-foundry-connection.bicep,app-service.bicep, etc.) and implemented detailed AVM modules for compute resources likecontainer-app.bicep,container-app-environment.bicep, andcontainer-instance.bicep. [1] [2] [3] [4]Deployment & Parameterization Enhancements
.github/workflows/deploy.yml,azure.yaml,azure_custom.yaml) are updated to support adeploymentFlavorparameter and to align with the new infra structure. This enables selection of deployment paths (e.g.,bicep,avm,avm-waf) and centralizes parameter files. [1] [2] [3]Documentation Updates
infra/scripts(including build, pre/post-provision, and utilities). [1] [2]References:
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information