Skip to content

Use throwing overloads in SetupTestDirectory#40964

Merged
beena352 merged 1 commit into
microsoft:masterfrom
beena352:user/beenachauhan/simplify/setup-test-directory
Jul 1, 2026
Merged

Use throwing overloads in SetupTestDirectory#40964
beena352 merged 1 commit into
microsoft:masterfrom
beena352:user/beenachauhan/simplify/setup-test-directory

Conversation

@beena352

@beena352 beena352 commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Summary of the Pull Request

Use throwing std::filesystem overloads. Addresses code review feedback.

PR Checklist

  • Closes: Link to issue #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated if needed and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated if needed
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Copilot AI review requested due to automatic review settings July 1, 2026 01:40

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR simplifies the WSLC e2e test helper SetupTestDirectory() by switching from std::filesystem error-code overloads plus manual THROW_HR_IF_MSG checks to the throwing overloads, reducing boilerplate in the test utilities.

Changes:

  • Replace remove_all(..., std::error_code&) + manual HRESULT checks with remove_all(...) throwing overload.
  • Replace create_directories(..., std::error_code&) + manual HRESULT checks with create_directories(...) throwing overload.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@beena352 beena352 marked this pull request as ready for review July 1, 2026 01:47
@beena352 beena352 requested a review from a team as a code owner July 1, 2026 01:47
@beena352 beena352 merged commit f2e0323 into microsoft:master Jul 1, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants