test: add probe test plan for Tool Auto Approve feature#306
Closed
ethanyhou wants to merge 1 commit into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new SWTBot test plan that validates the end-to-end integration surface of the unified Tool Auto Approve preferences page and its interactions with Agent Mode tool confirmations.
Changes:
- Introduces an
auto-approve.mdintegration test plan covering page rendering, org-policy gating, and cross-category confirmation/auto-approval behavior. - Defines P0/P1 test cases spanning terminal deny/allow flows, Global Auto Approve confirmation, and Reset-to-Defaults behavior.
- Adds a consolidated screenshots checklist for the key verification points.
Comment on lines
+16
to
+18
| ## Test Cases | ||
|
|
||
| ### TC-001: Tool Auto Approve preference page renders all four sections |
Comment on lines
+141
to
+155
| #### Preconditions | ||
| - Global Auto Approve is **disabled**. | ||
| - A Terminal **Deny** rule exists for `curl`. | ||
| - **Agent Mode** selected. | ||
|
|
||
| #### Steps | ||
| 1. Open **Tool Auto Approve → Global Auto Approve**. | ||
| 2. Click the **"Auto approve all tool calls"** checkbox. | ||
| 3. Observe the **"Enable Global Auto Approve?"** confirmation dialog warning | ||
| about the risk; click **Cancel** and verify the checkbox stays unchecked. | ||
| 4. Click the checkbox again and click **Confirm**; verify it is now checked. | ||
| 5. Click **Apply and Close**. | ||
| 6. In Agent Mode, trigger a `curl` terminal command (normally denied), then an | ||
| MCP tool call, then a file operation on a file outside the attached | ||
| context. |
Member
|
I already have separate test plans covering the auto-approve functionality. Could you please check whether these newly added test cases can be covered by, or merged into, the existing test cases? |
Member
|
Since we already have existing test plan for auto approve. Close this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.