refactor: validate format for PIT restore of SQL DB#248
Open
v-alexmoraru wants to merge 9 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds SQLDatabase point-in-time restore support to fab mkdir by validating restore parameters and emitting appropriate errors, with accompanying unit tests.
Changes:
- Added GUID and ISO8601-with-timezone validation helpers and SQLDatabase restore payload generation.
- Extended parameter help (
get_params_per_item_type) for SQLDatabase restore mode. - Added/expanded tests covering GUID/timestamp validation and SQLDatabase restore scenarios.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| tests/test_utils/test_fab_cmd_mkdir_utils.py | Adds tests for GUID/timestamp validators and SQLDatabase restore payload behavior. |
| src/fabric_cli/utils/fab_cmd_mkdir_utils.py | Implements SQLDatabase restore mode payload creation plus GUID/ISO8601 validation helpers. |
| src/fabric_cli/errors/mkdir.py | Adds mkdir-specific error messages for restore mode validation failures. |
Collaborator
|
@v-alexmoraru please add PR description and link the issue to it (by adding |
ayeshurun
reviewed
Jun 21, 2026
ayeshurun
reviewed
Jun 21, 2026
ayeshurun
reviewed
Jun 21, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
| GUID_PATTERN = re.compile( | ||
| r"^[a-fA-F0-9]{8}-[a-fA-F0-9]{4}-[a-fA-F0-9]{4}-[a-fA-F0-9]{4}-[a-fA-F0-9]{12}$" | ||
| ) | ||
| GUID_PATTERN_STR = r"([a-f0-9\-]{36})" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #149.
Validates the point-in-time restore property of SQL databases by ensuring the provided GUIDs and timestamps match the proper regex.