Skip to content

Harden physical-page linked-list traversal (LVBS/OP-TEE)#837

Open
sangho2 wants to merge 3 commits into
mainfrom
sanghle/fix-page-list
Open

Harden physical-page linked-list traversal (LVBS/OP-TEE)#837
sangho2 wants to merge 3 commits into
mainfrom
sanghle/fix-page-list

Conversation

@sangho2
Copy link
Copy Markdown
Contributor

@sangho2 sangho2 commented May 7, 2026

This PR hardens physical-page linked-list traversal in both LVBS (HEKI) and OP-TEE shim. Each implementation uses a page linked list to share data across non-contiguous physical pages. This PR adds additional validation to ensure these linked lists are well formed.

@sangho2 sangho2 marked this pull request as ready for review May 7, 2026 21:48
@sangho2 sangho2 changed the title Harden physical-page linked-list traversal Harden physical-page linked-list traversal (LVBS/OP-TEE) May 7, 2026
@sangho2 sangho2 added must-not-merge:blocked-on-other-changes Other changes/PRs to be handled first. Label not needed for non-main changes. and removed must-not-merge:blocked-on-other-changes Other changes/PRs to be handled first. Label not needed for non-main changes. labels May 15, 2026
Comment thread litebox_platform_lvbs/src/mshv/vsm.rs Outdated
let mut range: u64 = 0;

while range < nranges {
let cur_pa = next_pa;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to create cur_pa?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for a good catch. This is a legacy. Let me fix it.

Copy link
Copy Markdown
Member

@wdcui wdcui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@github-actions
Copy link
Copy Markdown

🤖 SemverChecks 🤖 No breaking API changes detected

Note: this does not mean API is unchanged, or even that there are no breaking changes; simply, none of the detections triggered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants