Skip to content

[1.29] Fix crash with --disable-interactivity and EFResume #6303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Trenly wants to merge 1 commit into
base: release-v1.29
Choose a base branch
from
+3 −0
Draft

[1.29] Fix crash with --disable-interactivity and EFResume #6303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/ReleaseNotes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,3 +87,4 @@ Added a user setting (`logging.fileNameStrategy`) for controlling the default na
* `winget validate` now performs case-insensitive comparison for file extensions where applicable
* `winget source reset` now properly resets default sources instead of removing them
* DSC v3 `Microsoft.WinGet/Package` resource now honors the `installMode` property to use silent or interactive installer switches as specified
* Fixed a crash (`0x8000ffff`) when using `--disable-interactivity` with the Resume experimental feature enabled during install operations.
2 changes: 2 additions & 0 deletions src/AppInstallerCLICore/Argument.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,6 +448,8 @@ namespace AppInstaller::CLI
return Argument{ type, Resource::String::NoProgressArgumentDescription, ArgumentType::Flag, Argument::Visibility::Hidden };
case Args::Type::VerboseLogs:
return Argument{ type, Resource::String::VerboseLogsArgumentDescription, ArgumentType::Flag };
case Args::Type::DisableInteractivity:
return Argument{ type, Resource::String::DisableInteractivityArgumentDescription, ArgumentType::Flag, false };
case Args::Type::CustomHeader:
return Argument{ type, Resource::String::HeaderArgumentDescription, ArgumentType::Standard, Argument::Visibility::Help };
case Args::Type::AcceptSourceAgreements:
Expand Down
Loading