fix: flag schema derive on schemars feature#966
Merged
Conversation
DaleSeo
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most
derive(schemars::JsonSchema)s are flagged on theschemarsfeature, except for one instance (EmptyObject) which was flagged onserver. This seems like a mistake, and means that enabling onlyschemarsmisses this one type.Also changes the
serverfeature to include theschemarsfeature itself, not just the dep. This does increate the server API, but preserves compatibility and I think aligns with the intention.Motivation and Context
Makes rmcp buildable with only the schemars feature
How Has This Been Tested?
cargo check -p rmcp --no-default-features --features servercargo check -p rmcp --no-default-features --features schemarsBreaking Changes
No breaking changes
Types of changes
Checklist
Additional context