Skip to content

test: stabilize JavaScript dependency install #972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DaleSeo wants to merge 1 commit into
base: main
Choose a base branch
from
+20 −18
Open

test: stabilize JavaScript dependency install #972

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 20 additions & 18 deletions crates/rmcp/tests/test_with_js.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,23 @@ use common::calculator::Calculator;

const STREAMABLE_HTTP_BIND_ADDRESS: &str = "127.0.0.1:8001";
const STREAMABLE_HTTP_JS_BIND_ADDRESS: &str = "127.0.0.1:8002";
// These tests run concurrently, while npm mutates their shared node_modules directory.
static JS_DEPENDENCIES_INSTALLED: tokio::sync::OnceCell<()> = tokio::sync::OnceCell::const_new();

async fn install_js_dependencies() -> anyhow::Result<()> {
JS_DEPENDENCIES_INSTALLED
.get_or_try_init(|| async {
let status = tokio::process::Command::new("npm")
.arg("install")
.current_dir("tests/test_with_js")
.status()
.await?;
anyhow::ensure!(status.success(), "npm install failed with {status}");
Ok(())
})
.await?;
Ok(())
}

#[tokio::test]
async fn test_with_js_stdio_server() -> anyhow::Result<()> {
Expand All @@ -27,12 +44,7 @@ async fn test_with_js_stdio_server() -> anyhow::Result<()> {
)
.with(tracing_subscriber::fmt::layer())
.try_init();
tokio::process::Command::new("npm")
.arg("install")
.current_dir("tests/test_with_js")
.spawn()?
.wait()
.await?;
install_js_dependencies().await?;
let transport =
TokioChildProcess::new(tokio::process::Command::new("node").configure(|cmd| {
cmd.arg("tests/test_with_js/server.js");
Expand All @@ -57,12 +69,7 @@ async fn test_with_js_streamable_http_client() -> anyhow::Result<()> {
)
.with(tracing_subscriber::fmt::layer())
.try_init();
tokio::process::Command::new("npm")
.arg("install")
.current_dir("tests/test_with_js")
.spawn()?
.wait()
.await?;
install_js_dependencies().await?;

let ct = CancellationToken::new();
let service: StreamableHttpService<Calculator, LocalSessionManager> =
Expand Down Expand Up @@ -104,12 +111,7 @@ async fn test_with_js_streamable_http_server() -> anyhow::Result<()> {
)
.with(tracing_subscriber::fmt::layer())
.try_init();
tokio::process::Command::new("npm")
.arg("install")
.current_dir("tests/test_with_js")
.spawn()?
.wait()
.await?;
install_js_dependencies().await?;

let transport = StreamableHttpClientTransport::from_uri(format!(
"http://{STREAMABLE_HTTP_JS_BIND_ADDRESS}/mcp"
Expand Down