fix(app): cache background refresh infinite loop during init#6255
Open
2clerway wants to merge 3 commits into
Open
fix(app): cache background refresh infinite loop during init#62552clerway wants to merge 3 commits into
2clerway wants to merge 3 commits into
Conversation
Only spawn cache background refresh tasks when State is already initialized. Prevents the spawned task from hang forever in the State::get() busy-wait loop when it fires before init completes.
Member
Pull request changelogAppAddedChangedDeprecatedRemovedFixedSecurityWebsiteAddedChangedDeprecatedRemovedFixedSecurityHostingAddedChangedDeprecatedRemovedFixedSecurity |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only spawn cache background refresh tasks when State is already initialized. Prevents the spawned task from hanging forever in the State::get() busy-wait loop when it fires before init completes.
Fixes the issue in this reddit post