fix: account for payouts_split in project revenue analytics#6269
Open
MicahXX wants to merge 1 commit into
Open
fix: account for payouts_split in project revenue analytics#6269MicahXX wants to merge 1 commit into
MicahXX wants to merge 1 commit into
Conversation
Analytics was showing total project revenue instead of the user's share. Fixed by joining team_members to multiply amount by the user's payouts_split percentage. Fixes the issue where a user with 50% split would see 100% of the project's revenue in analytics.
Member
Pull request changelogAppAddedChangedDeprecatedRemovedFixedSecurityWebsiteAddedChangedDeprecatedRemovedFixedSecurityHostingAddedChangedDeprecatedRemovedFixedSecurity |
IMB11
added
backend
Member
|
unfortunately, this isn't entirely accurate because your revenue split can change over time. by applying the current revenue split to historic data, it may show wildly higher or lower amounts than you received depending on if and when your split on a project changed. I think that's honestly worse than it is now, showing the full project's revenue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Analytics was showing total project revenue instead of the user's share. Fixed by joining team_members to multiply amount by the user's payouts_split percentage.
Fixes the issue where a user with 50% or any other split would see 100% of the project's revenue in analytics.
For reference, so i think analytics should show the actual revenue smbd gets
