Bug 2049067 - Don't fail if a previous code review task failed but already created Harbormaster URI#3444
Open
marco-c wants to merge 1 commit into
Open
Bug 2049067 - Don't fail if a previous code review task failed but already created Harbormaster URI#3444marco-c wants to merge 1 commit into
marco-c wants to merge 1 commit into
firefoxci-taskcluster / Code Review Bot checks: linting
succeeded
Jun 22, 2026 in 1m 6s
FirefoxCI (pull_request)
Check code style with pre-commit hooks
Details
View task in Taskcluster | View logs in Taskcluster | View task group in Taskcluster
Task Status
Started: 2026-06-22T12:47:13.997Z
Resolved: 2026-06-22T12:48:19.298Z
Task Execution Time: 1 minute, 5 seconds, 301 milliseconds
Task Status: completed
Reason Resolved: completed
TaskId: aFdyxkO8QlKBtJ_fyTzvYw
RunId: 0
Artifacts
- public/logs/live_backing.log
- public/logs/live.log
[taskcluster 2026-06-22T12:47:14.033Z] Worker Type (code-analysis-1/linux-gw-gcp) settings:
[taskcluster 2026-06-22T12:47:14.033Z] {
[taskcluster 2026-06-22T12:47:14.033Z] "config": {
[taskcluster 2026-06-22T12:47:14.033Z] "deploymentId": ""
[taskcluster 2026-06-22T12:47:14.033Z] },
[taskcluster 2026-06-22T12:47:14.033Z] "generic-worker": {
[taskcluster 2026-06-22T12:47:14.033Z] "engine": "multiuser",
[taskcluster 2026-06-22T12:47:14.033Z] "go-arch": "amd64",
[taskcluster 2026-06-22T12:47:14.033Z] "go-os": "linux",
[taskcluster 2026-06-22T12:47:14.033Z] "go-version": "go1.22.2",
[taskcluster 2026-06-22T12:47:14.033Z] "release": "https://github.com/taskcluster/taskcluster/releases/tag/v64.3.0",
[taskcluster 2026-06-22T12:47:14.033Z] "revision": "b66b6614b9b79077f1bfc78f97afb8c25c0c4b30",
[taskcluster 2026-06-22T12:47:14.033Z] "source": "https://github.com/taskcluster/taskcluster/commits/b66b6614b9b79077f1bfc78f97afb8c25c0c4b30",
[taskcluster 2026-06-22T12:47:14.033Z] "version": "64.3.0"
[taskcluster 2026-06-22T12:47:14.033Z] },
[taskcluster 2026-06-22T12:47:14.033Z] "image": "projects/taskcluster-imaging/global/images/gw-fxci-gcp-l1-gui-googlecompute-2024-08-22t22-48-09z",
[taskcluster 2026-06-22T12:47:14.033Z] "instance-id": "6907683410850123979",
[taskcluster 2026-06-22T12:47:14.033Z] "instance-type": "projects/887720501152/machineTypes/c2-standard-4",
[taskcluster 2026-06-22T12:47:14.033Z] "local-ipv4": "10.138.0.108",
[taskcluster 2026-06-22T12:47:14.033Z] "project-id": "fxci-production-level1-workers",
[taskcluster 2026-06-22T12:47:14.033Z] "public-hostname": "code-analysis-1-linux-gw-gcp-tl8vzrvcqko-vezsxdyl8q.c.fxci-production-level1-workers.internal",
[taskcluster 2026-06-22T12:47:14.033Z] "public-ipv4": "35.199.177.179",
[taskcluster 2026-06-22T12:47:14.033Z] "region": "us-west1",
[taskcluster 2026-06-22T12:47:14.033Z] "zone": "us-west1-a"
[taskcluster 2026-06-22T12:47:14.033Z] }
[taskcluster 2026-06-22T12:47:14.033Z] Task ID: aFdyxkO8QlKBtJ_fyTzvYw
[taskcluster 2026-06-22T12:47:14.033Z] === Task Starting ===
[taskcluster:warn 2026-06-22T12:47:14.036Z] This task was designed to run under Docker Worker. Docker Worker is no longer maintained.
[taskcluster:warn 2026-06-22T12:47:14.036Z] In order to execute this task, it is being converted to a Generic Worker task, using the D2G
[taskcluster:warn 2026-06-22T12:47:14.036Z] utility (Docker Worker 2 Generic Worker):
[taskcluster:warn 2026-06-22T12:47:14.036Z] https://github.com/taskcluster/taskcluster/tree/main/clients/client-shell#translating-docker-worker-task-definitionpayload-to-generic-worker-task-definitionpayload
[taskcluster:warn 2026-06-22T12:47:14.036Z]
[taskcluster:warn 2026-06-22T12:47:14.036Z] We recommend that you convert all your Docker Worker tasks to Generic Worker tasks, to ensure
[taskcluster:warn 2026-06-22T12:47:14.036Z] continued support. For this task, see the converted payload below. If you have many tasks that
[taskcluster:warn 2026-06-22T12:47:14.036Z] require conversion, consider using the d2g tool (above) directly. It simply takes a Docker
[taskcluster:warn 2026-06-22T12:47:14.036Z] Worker task payload as input, and outputs a Generic Worker task payload. It can also convert
[taskcluster:warn 2026-06-22T12:47:14.036Z] Docker Worker scopes to equivalent Generic Worker scopes.
[taskcluster:warn 2026-06-22T12:47:14.036Z]
[taskcluster:warn 2026-06-22T12:47:14.036Z] Converted task definition (conversion performed by d2g):
[taskcluster:warn 2026-06-22T12:47:14.036Z] ---
[taskcluster:warn 2026-06-22T12:47:14.036Z] created: "2026-06-22T12:44:09.753Z"
[taskcluster:warn 2026-06-22T12:47:14.036Z] deadline: "2026-06-22T13:44:09.753Z"
[taskcluster:warn 2026-06-22T12:47:14.036Z] dependencies: []
[taskcluster:warn 2026-06-22T12:47:14.036Z] expires: "2027-06-22T13:44:09.753Z"
[taskcluster:warn 2026-06-22T12:47:14.036Z] extra: {}
[taskcluster:warn 2026-06-22T12:47:14.036Z] metadata:
[taskcluster:warn 2026-06-22T12:47:14.036Z] description: Check code style with pre-commit hooks
[taskcluster:warn 2026-06-22T12:47:14.036Z] name: 'Code Review Bot checks: linting'
[taskcluster:warn 2026-06-22T12:47:14.036Z] owner: bastien@mozilla.com
[taskcluster:warn 2026-06-22T12:47:14.036Z] source: https://github.com/mozilla/code-review
[taskcluster:warn 2026-06-22T12:47:14.036Z] payload:
[taskcluster:warn 2026-06-22T12:47:14.036Z] command:
[taskcluster:warn 2026-06-22T12:47:14.036Z] - - bash
[taskcluster:warn 2026-06-22T12:47:14.036Z] - -cx
[taskcluster:warn 2026-06-22T12:47:14.036Z] - podman run -t --rm --privileged -e RUN_ID -e TASKCLUSTER_ROOT_URL -e TASKCLUSTER_WORKER_LOCATION
[taskcluster:warn 2026-06-22T12:47:14.036Z] -e TASK_ID 'python:3.12' sh -lxce 'git clone --quiet https://github.com/marco-c/code-review
[taskcluster:warn 2026-06-22T12:47:14.036Z] /src && cd /src && git checkout e81a2d26da4f8005a6331d7a21dc30fddc325313 -b
[taskcluster:warn 2026-06-22T12:47:14.036Z] checks && cd /src/bot && pip install --disable-pip-version-check --no-cache-dir
[taskcluster:warn 2026-06-22T12:47:14.036Z] --quiet -r requirements-dev.txt && cd /src && pre-commit run -a --show-diff-on-failure'
[taskcluster:warn 2026-06-22T12:47:14.036Z] features:
[taskcluster:warn 2026-06-22T12:47:14.036Z] backingLog: true
[taskcluster:warn 2026-06-22T12:47:14.036Z] liveLog: true
[taskcluster:warn 2026-06-22T12:47:14.036Z] logs:
[taskcluster:warn 2026-06-22T12:47:14.036Z] backing: public/logs/live_backing.log
[taskcluster:warn 2026-06-22T12:47:14.036Z] live: public/logs/live.log
[taskcluster:warn 2026-06-22T12:47:14.036Z] maxRunTime: 3600
[taskcluster:warn 2026-06-22T12:47:14.036Z] onExitStatus:
[taskcluster:warn 2026-06-22T12:47:14.036Z] retry:
[taskcluster:warn 2026-06-22T12:47:14.036Z] - 125
[taskcluster:warn 2026-06-22T12:47:14.036Z] - 128
[taskcluster:warn 2026-06-22T12:47:14.036Z] priority: lowest
[taskcluster:warn 2026-06-22T12:47:14.036Z] projectId: none
[taskcluster:warn 2026-06-22T12:47:14.036Z] provisionerId: code-analysis-1
[taskcluster:warn 2026-06-22T12:47:14.036Z] requires: all-completed
[taskcluster:warn 2026-06-22T12:47:14.036Z] retries: 5
[taskcluster:warn 2026-06-22T12:47:14.036Z] routes:
[taskcluster:warn 2026-06-22T12:47:14.036Z] - checks
[taskcluster:warn 2026-06-22T12:47:14.036Z] schedulerId: taskcluster-github
[taskcluster:warn 2026-06-22T12:47:14.036Z] scopes: []
[taskcluster:warn 2026-06-22T12:47:14.036Z] tags: {}
[taskcluster:warn 2026-06-22T12:47:14.036Z] taskGroupId: CqhtJ7k2SmCUY96Kd7bc_Q
[taskcluster:warn 2026-06-22T12:47:14.036Z] taskQueueId: code-analysis-1/linux-gw-gcp
[taskcluster:warn 2026-06-22T12:47:14.036Z] workerType: linux-gw-gcp
[taskcluster:warn 2026-06-22T12:47:14.036Z]
[taskcluster 2026-06-22T12:47:14.694Z] Uploading redirect artifact public/logs/live.log to URL https://firefoxci-websocktunnel.services.mozilla.com/us-west1-a.6907683410850123979.60099/log/OhuoomyrSuiwT6DJ2WjPBQ with mime type "text/plain; charset=utf-8" and expiry 2026-06-22T14:02:14.631Z
[taskcluster 2026-06-22T12:47:14.747Z] Executing command 0: bash -cx 'podman run -t --rm --privileged -e RUN_ID -e TASKCLUSTER_ROOT_URL -e TASKCLUSTER_WORKER_LOCATION -e TASK_ID '\''python:3.12'\'' sh -lxce '\''git clone --quiet https://github.com/marco-c/code-review /src && cd /src && git checkout e81a2d26da4f8005a6331d7a21dc30fddc325313 -b checks && cd /src/bot && pip install --disable-pip-version-check --no-cache-dir --quiet -r requirements-dev.txt && cd /src && pre-commit run -a --show-diff-on-failure'\'
+ podman run -t --rm --privileged -e RUN_ID -e TASKCLUSTER_ROOT_URL -e TASKCLUSTER_WORKER_LOCATION -e TASK_ID python:3.12 sh -lxce 'git clone --quiet https://github.com/marco-c/code-review /src && cd /src && git checkout e81a2d26da4f8005a6331d7a21dc30fddc325313 -b checks && cd /src/bot && pip install --disable-pip-version-check --no-cache-dir --quiet -r requirements-dev.txt && cd /src && pre-commit run -a --show-diff-on-failure'
Resolved "python" as an alias (/etc/containers/registries.conf.d/shortnames.conf)
Trying to pull docker.io/library/python:3.12...
Getting image source signatures
Copying blob sha256:d57bbc53353ecabb779b6c8f9b0af53272370a6ad158b763c050a8afab508f84
Copying blob sha256:2ca884014342f240be01d391b498c3ec61b2f4af2c205e7e9a0b5ac2cb2f24c4
Copying blob sha256:8b365b6ff7b7e310e1b9a88f996e65b89969c7fa450492b68249d1d1c38e0676
Copying blob sha256:442cca122a8b0987d6ea29e5fa7d0b8caf699cb127ec5fdbd8191faf86da521f
Copying blob sha256:71eb69eeaf0140423be38ed241ad5ddc36be392df1205a10bc5c976ee3ef4e8b
Copying blob sha256:ef1b08ddd59d42b444e8f9c68a6cebbed70636aed0c242fdccb0bd61b61ba26b
Copying blob sha256:442cca122a8b0987d6ea29e5fa7d0b8caf699cb127ec5fdbd8191faf86da521f
Copying blob sha256:8b365b6ff7b7e310e1b9a88f996e65b89969c7fa450492b68249d1d1c38e0676
Copying blob sha256:d57bbc53353ecabb779b6c8f9b0af53272370a6ad158b763c050a8afab508f84
Copying blob sha256:71eb69eeaf0140423be38ed241ad5ddc36be392df1205a10bc5c976ee3ef4e8b
Copying blob sha256:ef1b08ddd59d42b444e8f9c68a6cebbed70636aed0c242fdccb0bd61b61ba26b
Copying blob sha256:2ca884014342f240be01d391b498c3ec61b2f4af2c205e7e9a0b5ac2cb2f24c4
Copying blob sha256:d04536ac5ef055751b60fa87af5497578de31c633adeb26484adae16ae7ef4c5
Copying blob sha256:d04536ac5ef055751b60fa87af5497578de31c633adeb26484adae16ae7ef4c5
Copying config sha256:efb4d2320c4375e2fd32503ae4e81af163fef84f815193307c5d1e9bc8e13935
Writing manifest to image destination
Storing signatures
+ id -u
+ [ 0 -eq 0 ]
+ PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
+ export PATH
+ [ # ]
+ [ ]
+ id -u
+ [ 0 -eq 0 ]
+ PS1=#
+ [ -d /etc/profile.d ]
+ run-parts --list --regex ^[a-zA-Z0-9_][a-zA-Z0-9._-]*\.sh$ /etc/profile.d
+ unset i
+ [ ]
+ git clone --quiet https://github.com/marco-c/code-review /src
+ cd /src
+ git checkout e81a2d26da4f8005a6331d7a21dc30fddc325313 -b checks
Switched to a new branch 'checks'
+ cd /src/bot
+ pip install --disable-pip-version-check --no-cache-dir --quiet -r requirements-dev.txt
WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager, possibly rendering your system unusable. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv. Use the --root-user-action option if you know what you are doing and want to suppress this warning.
+ cd /src
+ pre-commit run -a --show-diff-on-failure
[INFO] Initializing environment for https://github.com/astral-sh/ruff-pre-commit.
[INFO] Initializing environment for https://github.com/pre-commit/mirrors-prettier.
[INFO] Initializing environment for https://github.com/pre-commit/mirrors-prettier:prettier@2.7.1.
[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
[WARNING] repo `https://github.com/pre-commit/pre-commit-hooks` uses deprecated stage names (commit, push) which will be removed in a future version. Hint: often `pre-commit autoupdate --repo https://github.com/pre-commit/pre-commit-hooks` will fix this. if it does not -- consider reporting an issue to that repo.
[INFO] Initializing environment for https://github.com/codespell-project/codespell.
[INFO] Initializing environment for https://github.com/marco-c/taskcluster_yml_validator.
[INFO] Initializing environment for https://github.com/asottile/yesqa.
[INFO] Installing environment for https://github.com/astral-sh/ruff-pre-commit.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/pre-commit/mirrors-prettier.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/codespell-project/codespell.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/marco-c/taskcluster_yml_validator.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/asottile/yesqa.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
ruff.....................................................................Passed
ruff-format..............................................................Passed
prettier.................................................................Passed
check python ast.........................................................Passed
check docstring is first.................................................Passed
check that executables have shebangs.....................................Passed
check for merge conflicts................................................Passed
check for broken symlinks............................(no files to check)Skipped
debug statements (python)................................................Passed
trim trailing whitespace.................................................Passed
check yaml...............................................................Passed
mixed line ending........................................................Passed
python tests naming......................................................Passed
check json...............................................................Passed
fix requirements.txt.....................................................Passed
check vcs permalinks.....................................................Passed
codespell................................................................Passed
taskcluster_yml..........................................................Passed
Strip unnecessary `# noqa`s..............................................Passed
Check for useless excludes...............................................Passed
[taskcluster 2026-06-22T12:48:18.915Z] Exit Code: 0
[taskcluster 2026-06-22T12:48:18.915Z] User Time: 26.381406s
[taskcluster 2026-06-22T12:48:18.915Z] Kernel Time: 4.7415s
[taskcluster 2026-06-22T12:48:18.915Z] Wall Time: 1m4.167617054s
[taskcluster 2026-06-22T12:48:18.915Z] Result: SUCCEEDED
[taskcluster 2026-06-22T12:48:18.915Z] === Task Finished ===
[taskcluster 2026-06-22T12:48:18.915Z] Task Duration: 1m4.168076078s
[taskcluster 2026-06-22T12:48:19.035Z] Uploading link artifact public/logs/live.log to artifact public/logs/live_backing.log with expiry 2027-06-22T13:44:09.753Z
Loading