Convert SummaryPanel and ActionBar to functional components#9635
Open
camd wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9635 +/- ##
========================================
Coverage 82.92% 82.93%
========================================
Files 618 618
Lines 36164 36145 -19
Branches 3239 3292 +53
========================================
- Hits 29989 29976 -13
+ Misses 6025 5791 -234
- Partials 150 378 +228 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
benoitgoupilleau
approved these changes
Jun 22, 2026
camd
force-pushed
the
camd/expired-jobs-details-panel
branch
from
65a4570 to
d4d7afc
Compare
camd
force-pushed
the
camd/functional-summary-actionbar
branch
from
a88953c to
2b7905c
Compare
camd
requested review from
a team,
beatrice-acasandrei and
esanuandra
as code owners
Convert the SummaryPanel and ActionBar class components to functional components with hooks: - SummaryPanel becomes a memoized function component. - ActionBar moves its lifecycle window-event listeners into a useEffect and reads decisionTaskMap directly from the pushes store, so the class wrapper is no longer needed. Its export becomes the function itself (the default export remains a memoized wrapper for compatibility). No behavior change.
camd
force-pushed
the
camd/functional-summary-actionbar
branch
from
2b7905c to
993b26f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Converts the
SummaryPanelandActionBarclass components in the job-view details panel to functional components with hooks. This is a pure refactor with no behavior change.openLogviewer,openRawLog,openGeckoProfile,jobRetrigger) into auseEffect, and readsdecisionTaskMapdirectly from the pushes store, so the class-to-store wrapper is no longer needed. The named export is now the function itself; the default export remains a memoized wrapper for compatibility.Notes
This PR is now independent of the expired-task handling work (previously stacked on
camd/expired-jobs-details-panel). It targetsmasterdirectly so it can be merged on its own. The two changes touch overlapping regions ofActionBar.jsx/SummaryPanel.jsx, so a small merge conflict is expected when the second of the two lands — but either can go first.