Update FullRainbow component values and footnote for clarity#2203
Update FullRainbow component values and footnote for clarity#2203djstrong wants to merge 6 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughRefactors BarChart rendering/layout (percent computation, external percent label, rainbow fill width transition) and updates FullRainbow BarChart dataset: "ENS Subgraph" set to 11, "Current" and "Target" bar values/gradients adjusted (Target replaces Future target and includes ENSRainbowBeam), and footnote expanded to note encoded labelhashes for unnormalized names. ChangesENS Rainbow Chart Updates
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint skipped: no ESLint configuration detected in root package.json. To enable, add Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR updates the ENSRainbow docs “FullRainbow” chart to reflect revised coverage values and clarifies the explanatory footnote for how results are calculated.
Changes:
- Adjusted the displayed coverage values for “ENS Subgraph”, “ENSRainbow + ENSNode (Current)”, and the target configuration.
- Updated the target label to “ENSRainbow + ENSNode + ENSRainbowBeam” and changed the badge text from “Future target” to “Target”.
- Expanded the footnote to clarify that certain unnormalized/encoded-labelhash formatted names are excluded from results.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Greptile SummaryThis PR updates the
Confidence Score: 5/5Safe to merge — changes are limited to display data values, gradient stops, a label rename, a footnote expansion, and a layout refactor of the bar chart percentage label. All changes are in documentation/marketing UI components with no business logic, API calls, or shared utilities touched. The bar chart refactor is a straightforward layout improvement, and the data updates are intentional corrections to coverage figures. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[BarChart receives data array] --> B[For each item, compute percent = item.value / maxValue × 100]
B --> C{Is this the last item?}
C -- Yes --> D[percentLabel = '+' + percent + '%']
C -- No --> E[percentLabel = percent + '%']
D --> F[Render label span above bar]
E --> F
F --> G[Render grey background bar container]
G --> H[Render colored inner bar at width=percent%]
H --> I[Render percentLabel span outside/right of bar]
I --> J{More items?}
J -- Yes --> K[Render divider line]
K --> B
J -- No --> L[Render footnote below chart]
Reviews (4): Last reviewed commit: "fix bar chart (#2207)" | Re-trigger Greptile |
| label: <>ENS Subgraph</>, | ||
| value: 19, | ||
| color: "linear-gradient(90deg, #EA2F86 0%, #CA01FD 0.5%, #0B10FE 80%)", | ||
| value: 11, | ||
| color: "linear-gradient(90deg, #EA2F86 0%, #CA01FD 4.5%, #0B10FE 154.5%)", | ||
| }, |
| ]} | ||
| title="Name Healing Coverage" | ||
| footnote="Coverage vs. indexing the ENS Subgraph with no rainbow tables as of 26 May, 2026." | ||
| footnote="Coverage vs. indexing the ENS Subgraph with no rainbow tables as of 26 May, 2026. Results exclude unnormalized names that are formatted as encoded labelhashes in the ENS Subgraph but are actually known." |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| ]} | ||
| title="Name Healing Coverage" | ||
| footnote="Coverage vs. indexing the ENS Subgraph with no rainbow tables as of 26 May, 2026." | ||
| footnote="Coverage vs. indexing the ENS Subgraph with no rainbow tables as of 26 May, 2026. Results exclude unnormalized names that are formatted as encoded labelhashes in the ENS Subgraph but are actually known." |
There was a problem hiding this comment.
| footnote="Coverage vs. indexing the ENS Subgraph with no rainbow tables as of 26 May, 2026. Results exclude unnormalized names that are formatted as encoded labelhashes in the ENS Subgraph but are actually known." | |
| footnote="Coverage vs. indexing the ENS Subgraph with no rainbow tables as of 26 May, 2026. Results exclude unnormalized names that are formatted as encoded labelhashes in the ENS Subgraph but whose underlying names are actually known." |
Footnote has grammatically incomplete phrase "but are actually known" without clarifying what is known
Lite PR
Tip: Review docs on the ENSNode PR process
Summary
Why
Testing
Notes for Reviewer (Optional)
Pre-Review Checklist (Blocking)