Include whether allocation's project is externally funded#69
Open
QuanMPhm wants to merge 1 commit into
Open
Conversation
knikolla
requested changes
Jun 9, 2026
| pi = serializers.SerializerMethodField() | ||
| field_of_science = serializers.SerializerMethodField() | ||
| status = serializers.SerializerMethodField() | ||
| is_externally_funded = serializers.SerializerMethodField() |
Collaborator
There was a problem hiding this comment.
This approach would require explicitly adding every Project Attributes type individually to the API which is not scalable.
Why are you not outputting all Project Attributes The same way we do with Allocation Attributes?
Contributor
Author
There was a problem hiding this comment.
From local testing, it seems the API would output this if the Is Externally Funded attribute is not defined:
'attributes' : {
'Is Externally Funded': None
}
But I can see the appeal of just not having the field appear at all, and to just copy how allocation attributes are handled
Updated test cases to work with the latest version of `coldfront-plugin-cloud`, as changes to the quota system [1] broke the tests. [1] nerc-project/coldfront-plugin-cloud#287
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #70. Part of letting Coldfront projects show whether they are externally funded. I've added the boolean field in the API