feat(capabilities): dynamic mimetype discovery from wopi xml#5754
feat(capabilities): dynamic mimetype discovery from wopi xml#5754multiphlow wants to merge 3 commits into
Conversation
97602f5 to
2ffa5bf
Compare
|
Thanks for opening your first pull request here, it means a lot that you want to contribute. This change is especially welcome. In order to get this in, it would be nice if you could address the following:
If you need help with any of those, please feel free to reach out; I'm more than happy to assist! |
|
Actually the cypress failures seem indeed related and seem to tigger a javascript error: |
46efc8f to
497cf2d
Compare
|
@juliusknorr A while ago I fixed the issue with array_unique. |
Signed-off-by: Florian Wagner <f.wagner81@gmail.com>
Signed-off-by: Florian Wagner <f.wagner81@gmail.com>
Signed-off-by: Florian Wagner <f.wagner81@gmail.com>
e61b85b to
b3827c3
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Fixes #5742. This PR introduces dynamic mimetype discovery by parsing the WOPI discovery.xml using XPath, fallback in Capabilities is the static mimetypes array to ensure core stability.
Note: There are still some files in the code where Capabilities::MIMETYPES is used. This has to be correctly changed via dependency injection to use the new dynamic obtaining of the MIMETYPES
Furthermore a/some UnitTest(s) would also be required in DiscoveryServiceTest class.
Further on the discovery endpoint does not yet provide categories for the mimetypes.