docs:opkg: clean up RST#91
Conversation
a51fc44 to
b8f9f4c
Compare
Patch V2
|
There was a problem hiding this comment.
Pull Request Overview
This PR cleans up and improves the RST documentation for opkg tutorials by addressing minor formatting issues and improving readability. The changes focus on:
- Replacing bold formatting with inline literal markup for code elements and applications
- Changing references from ".ipks" and ".debs" to "IPKs" and "DEBs" for consistency
- Reflowing prose to break on sentence boundaries for better diff readability
- Minor content clarifications and link reference improvements
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| docs/source/opkg/opkg_intro.rst | Updates formatting, terminology, and prose flow for the basic opkg tutorial |
| docs/source/opkg/dkms_opkg.rst | Applies similar formatting and terminology improvements to the DKMS-based kernel module tutorial |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
* Fixup minor RST layout issues. * Use inline literal markup for inline code and applications, rather than bold. * Refer to IPKs and DEBs, instead of .ipks and .debs in most places. * Reflow prose to line-break on sentence ends, for easier diffing. * Minor content changes for clarity. Signed-off-by: Alex Stewart <alex.stewart@emerson.com>
Signed-off-by: Alex Stewart <alex.stewart@emerson.com>
Signed-off-by: Alex Stewart <alex.stewart@emerson.com>
Let's not check binary tarballs into the git source. Instead, we can build the example IPK tars from Make. Signed-off-by: Alex Stewart <alex.stewart@emerson.com>
No reason to advertise Charlie Johnston's defunct email when we can just use the generic email address for the RTOS team. Signed-off-by: Alex Stewart <alex.stewart@emerson.com>
b8f9f4c to
b98ad7e
Compare
Patch v2
|
|
When I build and preview the HTML content locally, I see a lot of lines wrapping with syllable-boundary hyphenation. Wrapping on word boundaries seems more readable. Was this intentional or just an unintended side effect? |
|
When I extract the new locally built dkms_opkg.tar.gz archive, I noticed that it lost the containing dkms_opkg directory upon extraction. Instead it extracts the hello and module_src directories directly into the current directory. This is different than opkg_intro.tar.gz and different than the old dkms_opkg.tar.gz. Perhaps unintended? |
I didn't do anything to effect the word-braking logic. I see places on the published docs that sphinx breaks the word as well.
https://nilrt-docs.ni.com/opkg-keyrings/opkg-keyrings_index.html#systemlink Copilot tells me that this behavior is controlled by the browser and your CSS. We could modify our sphinxdocs theme to tell it not to break words. But that isn't a part of this PR's purpose. |
These are the example IPKs I just downloaded from the published site. They seem similar to what we package with this PR. Are you seeing something different? Though now that I look at them more closely... I'm not sure these are good examples of IPKs. Especially the DKMS one seems malformed. |
|
I'll take a deeper look at the example IPKs when I have some time. |
* Converted the hello world c-code example to a more neutral bash script. * Corrected the opkg-intro source so that it follows a normal IPK layout. * Simplified and refactored the example text to walk the user through using opkg-build to create an IPK from the source. Signed-off-by: Alex Stewart <alex.stewart@emerson.com>
The current HTML output will set 'word-break: auto' which will direct the browser to "intelligently" break words with a hyphen across newlines. We'd prefer that it not. So set it to 'manual' in a custom css override, so that it will only break if the word itself contains a hyphen at that place. Signed-off-by: Alex Stewart <alex.stewart@emerson.com>
RST image embeds require a blank line before teh directive to parse correctly. Signed-off-by: Alex Stewart <alex.stewart@emerson.com>
* Rename ``dkms_opkg`` to ``dkms-opkg``, which is more standard for IPKs and archives. * Adjust Makefile TAR command so that the source archives have a containing folder - which is good practice. Signed-off-by: Alex Stewart <alex.stewart@emerson.com>
Signed-off-by: Alex Stewart <alex.stewart@emerson.com>
Instead of delivering two copies of the dkms module source code, just give readers the IPK-structured data, which includes the module source anyway. Signed-off-by: Alex Stewart <alex.stewart@emerson.com>
Instead of copying source file contents into the RST manually, we should let sphinx do it for us with literalinclude. Signed-off-by: Alex Stewart <alex.stewart@emerson.com>
Signed-off-by: Alex Stewart <alex.stewart@emerson.com>
Patch v3
|

Summary
Testing
make htmllocally and manually validated that the opkg tutorials look better and the links work.