Skip to content

lookup: re-add winston#983

Draft
Trott wants to merge 2 commits into
mainfrom
re-add-winston
Draft

lookup: re-add winston#983
Trott wants to merge 2 commits into
mainfrom
re-add-winston

Conversation

@Trott

@Trott Trott commented Sep 24, 2023

Copy link
Copy Markdown
Member
Checklist
  • npm test passes
  • contribution guidelines followed
    here

@codecov-commenter

codecov-commenter commented Sep 24, 2023

Copy link
Copy Markdown

Codecov Report

Patch and project coverage have no change.

Comparison is base (f15c9a2) 96.44% compared to head (bc73fe5) 96.44%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #983   +/-   ##
=======================================
  Coverage   96.44%   96.44%           
=======================================
  Files          28       28           
  Lines        2139     2139           
=======================================
  Hits         2063     2063           
  Misses         76       76           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Trott

Trott commented Aug 1, 2024

Copy link
Copy Markdown
Member Author

Looks like the tests are passing now and this can land?

@targos

targos commented Aug 4, 2024

Copy link
Copy Markdown
Member

@targos

targos commented Aug 5, 2024

Copy link
Copy Markdown
Member

It failed on Windows.

@Trott

Trott commented Aug 6, 2024

Copy link
Copy Markdown
Member Author

It failed on Windows.

Maybe we can re-add it with skipping Windows then?

@targos

targos commented Aug 7, 2024

Copy link
Copy Markdown
Member

@Trott

Trott commented Aug 7, 2024

Copy link
Copy Markdown
Member Author

Sure, here's a full CI job: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker-pipeline/258/

Looks like it's still failing. Oh well. Back to draft mode until someone wants to look into it or enough time has passed that it makes sense to try again.

@Trott Trott marked this pull request as draft August 7, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants