http: call _writeRaw callback when destroyed#63447
Open
trivikr wants to merge 1 commit into
Open
Conversation
Fixes: nodejs#36673 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5
Collaborator
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63447 +/- ##
==========================================
- Coverage 90.06% 90.04% -0.02%
==========================================
Files 714 714
Lines 225918 225928 +10
Branches 42734 42732 -2
==========================================
- Hits 203464 203438 -26
- Misses 14232 14275 +43
+ Partials 8222 8215 -7
🚀 New features to boost your workflow:
|
ronag
approved these changes
May 20, 2026
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OutgoingMessage._writeRaw()could return early without invoking the writecallback when the message, or its socket, was already destroyed.
This updates
_writeRaw()to call the callback withERR_STREAM_DESTROYEDin those cases, matching the existing destroyed
write()behavior.Fixes: #36673
Assisted-by: openai:gpt-5.5