Skip to content

feat(snowflake): add shared-utils SQL API foundation#27

Merged
hampsterx merged 1 commit into
masterfrom
feat/snowflake-shared-utils-client
Jun 26, 2026
Merged

feat(snowflake): add shared-utils SQL API foundation#27
hampsterx merged 1 commit into
masterfrom
feat/snowflake-shared-utils-client

Conversation

@hampsterx

Copy link
Copy Markdown
Contributor

Summary

  • Document shared-utils Snowflake credential, lifecycle, query hook, and offline testing patterns so API and Lambda consumers can adopt the SQL API client consistently.
  • Pin the Snowflake extra and dev setup to the pushed snowflake-sql-api v0.1.1 tag so fresh installs can resolve the testing helpers without a raw commit hash.
  • Add an offline async smoke test proving create_async_snowflake_client can query through FakeSnowflake with explicit analytics role and warehouse overrides.

Test plan

  • python3 TOML parse check for pyproject.toml
  • Install snowflake-sql-api from GitHub tag v0.1.1 in a fresh temp venv and import version 0.1.1
  • env PYTHONPATH=/home/tim/NUI/snowflake-sql-api pytest tests/test_snowflake_client.py -q
  • pytest tests/test_testing.py -q in sibling snowflake-sql-api
  • black --check tests/test_snowflake_client.py
  • Kimi review pass, minor import nit addressed

Notes

  • Live Snowflake smoke is still a downstream phase gate and was not run here.
  • markdownlint-cli2 currently picks up repo-wide globs including untracked .serena and handover docs; scoped base markdownlint could not run because npm registry lookup failed locally.

@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@hampsterx, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 7 minutes and 45 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c9c3f7ce-3684-488b-a84e-fc615131bb80

📥 Commits

Reviewing files that changed from the base of the PR and between 342b24b and b49babf.

📒 Files selected for processing (6)
  • README.md
  • docs/README.md
  • docs/guides/snowflake-integration.md
  • pyproject.toml
  • requirements-test.txt
  • tests/test_snowflake_client.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/snowflake-shared-utils-client

Comment @coderabbitai help to get the list of available commands.

- Document shared-utils Snowflake credential, lifecycle, query hook, and offline testing patterns so API and Lambda consumers can adopt the SQL API client consistently.
- Pin the Snowflake extra and dev setup to the pushed snowflake-sql-api v0.1.1 tag so fresh installs can resolve the testing helpers without a raw commit hash.
- Add an offline async smoke test proving create_async_snowflake_client can query through FakeSnowflake with explicit analytics role and warehouse overrides.
@hampsterx hampsterx force-pushed the feat/snowflake-shared-utils-client branch from d2860db to b49babf Compare June 26, 2026 02:30
@hampsterx

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@hampsterx

Copy link
Copy Markdown
Contributor Author

@coderabbitai review full

@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown

@hampsterx Re-running a full review of the PR now.

✅ Action performed

Full review finished.

@hampsterx hampsterx merged commit 7d79d1f into master Jun 26, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant