refactor(auth): remove non-conformant Display from issuer metadata#4347
Open
reinkrul wants to merge 1 commit into
Open
refactor(auth): remove non-conformant Display from issuer metadata#4347reinkrul wants to merge 1 commit into
reinkrul wants to merge 1 commit into
Conversation
The `display` field on OpenIDCredentialIssuerMetadata was not conform the OpenID4VCI spec (section 12.2.4). Its values were never consumed and it caused issues with the AET integration. Since nothing reads it, removal is safe. Assisted by AI
reinkrul
requested review from
gerardsn,
stevenvegt and
woutslakhorst
as code owners
Contributor
|
Coverage Impact ⬆️ Merging this pull request will increase total coverage on 🛟 Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the
displayfield fromOpenIDCredentialIssuerMetadata.Rationale
displayfield (typed[]map[string]string) was not conform the OpenID4VCI spec (section 12.2.4).display)Since nothing reads these values, removal is safe.
Changes
Displayfield fromauth/openid4vci/types.go.Display: nilreferences inauth/api/iam/openid4vci_test.go.🤖 Assisted by AI