Skip to content

fix(security): allow disabling proxy signing with security: false#790

Merged
harlan-zw merged 5 commits into
mainfrom
fix/disable-proxy-security
May 21, 2026
Merged

fix(security): allow disabling proxy signing with security: false#790
harlan-zw merged 5 commits into
mainfrom
fix/disable-proxy-security

Conversation

@harlan-zw
Copy link
Copy Markdown
Collaborator

🔗 Linked issue

Follow-up to #789 / #783

❓ Type of change

  • 📖 Documentation
  • 🐞 Bug fix
  • 👌 Enhancement
  • ✨ New feature
  • 🧹 Chore
  • ⚠️ Breaking change

📚 Description

#789 added a security.pageToken flag, but disabling only the token still leaves signing enforcement on, so client-side reactive proxy calls 403. This replaces that with a single, complete opt-out.

security now accepts false. When set, the module resolves no secret, auto-generates nothing into .env, skips the page token plugin, and withSigning passes proxy requests through without verification. This gives a deterministic SSR payload (stable etag) with no partial-security footguns. Docs updated.

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 21, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
scripts-playground Error Error May 21, 2026 6:40am

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 21, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3416f158-91eb-4922-ba39-b55c295838df

📥 Commits

Reviewing files that changed from the base of the PR and between 4738a27 and e549e61.

📒 Files selected for processing (2)
  • docs/content/docs/1.guides/2.first-party.md
  • packages/script/src/module.ts

📝 Walkthrough

Walkthrough

This PR adds support for disabling proxy security in the Nuxt Scripts module. The ModuleOptions.security type is updated to accept false alongside its existing object configuration, allowing users to fully disable proxy HMAC URL signing and page-token verification. The module setup logic now detects when security === false and skips secret resolution and server page-token plugin installation. Documentation and troubleshooting guidance explain the feature and its effects on SSR payload consistency.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: allowing proxy signing to be disabled via a security: false configuration option.
Description check ✅ Passed The description is directly related to the changeset, explaining the bug being fixed, the solution implemented, and how it differs from the previous approach.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/disable-proxy-security
⚔️ Resolve merge conflicts
  • Resolve merge conflict in branch fix/disable-proxy-security

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

…urity

# Conflicts:
#	docs/content/docs/1.guides/2.first-party.md
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 21, 2026

Open in StackBlitz

npm i https://pkg.pr.new/@nuxt/scripts@790

commit: 81686c8

@harlan-zw harlan-zw merged commit dc11ae0 into main May 21, 2026
14 of 15 checks passed
@harlan-zw harlan-zw deleted the fix/disable-proxy-security branch May 21, 2026 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant