fix: scope status Applied count to the project's own migrations (#31)#150
Open
alvarogar4 wants to merge 1 commit into
Open
fix: scope status Applied count to the project's own migrations (#31)#150alvarogar4 wants to merge 1 commit into
alvarogar4 wants to merge 1 commit into
Conversation
On a shared ObsessionDB journal table the `Applied` count was read globally from the journal, counting other tenants'/projects' rows and sometimes showing `Applied` greater than `Total`. Scope it (and the --json `applied` field) to migrations present in this project's migrations directory, so the count is always an intersection and never exceeds `Total`. Live-verified against the ObsessionDB test cluster with a two-project shared-journal e2e test (mutation-checked: fails as Applied=2 without the fix). Refs NUM-7318. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vs5ZySdFPLkAz33L1TEEZk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
statuscomputedAppliedfrom the whole journal table. On a shared ObsessionDB journal that counts other tenants'/projects' rows, soAppliedcould exceedTotaland erode trust in the bookkeeping (audit finding refactor: rename CLI package from @chkit/cli to chkit #31).Applied(and the--jsonappliedfield) to migrations present in this project's migrations directory — always an intersection with the local files, so it can never exceedTotal.Test plan
status-applied-scope.e2e.test.ts): two independent projects share one journal table; after both apply, project B'sstatusmust reportapplied=1(its own), not2.Applied=2).typecheck+lintpass.Part of NUM-7318 (Tier-3 safety/resilience polish). 1 of 4: #31.
🤖 Generated with Claude Code