fix: don't silently skip unmarked migrations under --table (#36)#151
Open
alvarogar4 wants to merge 1 commit into
Open
fix: don't silently skip unmarked migrations under --table (#36)#151alvarogar4 wants to merge 1 commit into
alvarogar4 wants to merge 1 commit into
Conversation
`migrate --apply --table <t>` parsed `-- operation:` markers to decide which pending migrations affect the selected tables. A hand-written migration with no markers was treated as affecting no tables and silently skipped, so the user believed all pending work had applied — a quiet correctness gap. Fail-safe: include migrations whose target tables can't be determined, and surface them — a warning in human output and a new `undeterminedMigrations` array in `--json` output. Documented in cli/migrate.md. Live-verified against the ObsessionDB test cluster (unmarked migration is applied under --table and its table created; mutation-checked: the field is absent and the table is never created without the fix). Refs NUM-7318. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vs5ZySdFPLkAz33L1TEEZk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
migrate --apply --table <t>decided scope by parsing-- operation:markers. A hand-written migration with no markers was treated as affecting no tables and silently skipped, so the user believed all pending work had applied — a quiet correctness gap (audit finding fix: create database in e2e fixture to prevent flaky tests #36).--tableand reported — a warning in human output, and a newundeterminedMigrationsarray in--jsonoutput. Documented incli/migrate.md.Test plan
table-scope-unmarked.e2e.test.ts): an unmarked migration applied under--tableactually creates its table and appears inundeterminedMigrations.typecheck+lintpass.Part of NUM-7318 (Tier-3 safety/resilience polish). 2 of 4: #36.
🤖 Generated with Claude Code