fix: order materialized-view creates by dependsOn (#41)#152
Open
alvarogar4 wants to merge 1 commit into
Open
Conversation
Create operations within the same kind were tie-broken purely by name (key.localeCompare). A refreshable materialized view declared `DEPENDS ON other_mv` whose name sorts before its dependency could be created first and fail. The planner now derives a creation depth from `refresh.dependsOn` and orders a DEPENDS ON target before the view that depends on it; independent views keep their stable alphabetical order. A dependency cycle falls back to the name order rather than looping. Verified with a unit test of two interdependent MVs whose names sort the wrong way (mutation-checked: dependent sorts first without the fix). Refs NUM-7318. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vs5ZySdFPLkAz33L1TEEZk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
key.localeCompare). A refreshable materialized view declaredDEPENDS ON other_mvwhose name sorts before its dependency could be created first and fail (audit finding docs: require bun verify before creating PRs #41).refresh.dependsOnand orders aDEPENDS ONtarget before the view that depends on it. Independent views keep their stable alphabetical order; a dependency cycle falls back to name order rather than looping.Test plan
planner-mv-order.test.ts): two interdependent MVs whose names sort the wrong way are ordered dependency-first; independent MVs stay alphabetical.typecheck+lintpass.Part of NUM-7318 (Tier-3 safety/resilience polish). 3 of 4: #41.
🤖 Generated with Claude Code