fix: Explicitly set boundary for multipart/form-data#1005
Merged
Conversation
dbanty
changed the title
dbanty
force-pushed
the
multipart-boundary
branch
from
e48dfc7 to
9c3f8b1
Compare
dbanty
force-pushed
the
multipart-boundary
branch
from
9c3f8b1 to
cb36cbd
Compare
dbanty
approved these changes
May 30, 2026
Merged
via the queue into
openapi-generators:main
with commit May 30, 2026
fb3f866
41 of 43 checks passed
Merged
iloveitaly
pushed a commit
to iloveitaly/openapi-python-client
that referenced
this pull request
May 31, 2026
> [!IMPORTANT] > Merging this pull request will create this release ## Breaking Changes - Drop support for Python 3.10 - Raise minimum httpx version to 0.23.1 ## Features - replace python-dateutil with stdlib datetime.fromisoformat (openapi-generators#1429) ## Fixes - Remove some generated casts that aren't necessary with mypy v2 (openapi-generators#1436) - Explicitly set boundary for multipart/form-data (openapi-generators#1005) Co-authored-by: knope-bot[bot] <152252888+knope-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actual Behavior
When an endpoint only has one body type, which is
multipart/form-data, theContent-Typeheader is not set, so that HTTPX can set it with the correct boundary.However, when an endpoint has multiple body types, the
Content-Typeheader is always set, and HTTPX do not override it, which results in a missing boundary formultipart/form-databody types (resulting in a400 - Bad Requestresponse from the servers).Proposed Changes
Let's always set the boundary to
+++to avoid any potential problem.NB: This is kind of related to #1004, since in my specific case, the
multipart/form-databody type is the last, it is always the one that is used.