test(coreApiWebdavUploadTUS): assert etag and permissions on the finalizing TUS chunk#3078
Open
michaelstingl wants to merge 1 commit into
Open
Conversation
…lizing TUS chunk The chunked TUS finalize returns OC-ETag, ETag and OC-Perm since opencloud-eu/reva#718, so a client no longer needs a follow-up PROPFIND for the new etag and permissions. Add a scenario asserting these headers on the finalizing chunk, reusing existing step definitions (the etag is a dynamic quoted hash, hence the header-regex assertion). Verified locally red->green: red on stock (headers absent), green on an opencloud built on a reva carrying that change, on posix and decomposed. opencloud-eu#2409
Up to standards ✅🟢 Issues
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
This scenario asserts headers that only a reva carrying the following change returns on the chunked TUS finalize:
This repo's reva pin (
v2.46.4-0.20260625152426-8cff2a7032ec, 2026-06-25) predates that merge, so the scenario is red until the pin is bumped past it. It goes green with the bump; no code change here.Description
Adds one scenario to
tests/acceptance/features/coreApiWebdavUploadTUS/lowLevelUpload.feature: after a chunked TUS upload's finalizing PATCH, the response carriesOC-ETag,ETagandOC-Perm, so a client does not need a follow-up PROPFIND for the new etag and permissions.Reuses existing step definitions only (TUS create +
sends a chunk+the following headers should match these regular expressions); the etag is a dynamic quoted hash, hence the regex assertion.Related Issue
Locks the behaviour from #2409 (closed) in the acceptance suite. The fix itself is in reva:
Motivation and Context
The chunked finalize returning the etag was covered only by a reva unit test. This pins it at the product boundary so a later regression fails the suite, and states the intended behaviour as an executable spec rather than an implicit claim.
How Has This Been Tested?
Locally, one feature against a running server, on two builds:
opencloud-rolling:7.1(before the reva change): create, chunks and204pass; the three header rows fail because the headers are absent.lowLevelUpload.featurepasses on posix and decomposed, the new scenario on old/new/spaces.Screenshots (if appropriate):
Types of changes
Checklist:
🤖 drafted with Claude Code, reviewed before submitting.