test(apiArchiver): the single-resource archive is named after the resource#3080
Open
michaelstingl wants to merge 1 commit into
Open
test(apiArchiver): the single-resource archive is named after the resource#3080michaelstingl wants to merge 1 commit into
michaelstingl wants to merge 1 commit into
Conversation
…ource An archive download of a single folder was always named "download.zip" until the handler resolved the resource name for the Content-Disposition header (opencloud-eu/reva#661). Add a scenario asserting the archive of a folder carries a Content-Disposition filename of the folder, reusing the archiver download step and the header-regex assertion. Verified red->green on posix and decomposed: red on an opencloud built on a reva with the change reverted (the archive is "download.zip"), green on the shipped reva.
Up to standards ✅🟢 Issues
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds one scenario to
tests/acceptance/features/apiArchiver/downloadById.feature: the archive of a single folder carries aContent-Dispositionfilename of the folder (for examplemy_data.zip), not the constantdownload.zip.It reuses existing steps only: the archiver download step (which stores the response) and the generic
the following headers should match these regular expressionsassertion. No new step-def.Related Issue
Enhancement tracked in reva:
The fix is reva:
Motivation and Context
A single-folder archive download was always named
download.zip/download.taruntil the handler resolved the resource name for theContent-Dispositionheader. The existingapiArchiverscenarios assert only the archive contents, never the filename, so this pins the naming at the product boundary.How Has This Been Tested?
Locally, the feature against a running server, on two builds and both storages:
downloadById.featurepasses on posix and decomposed (11/11), the new scenario green on zip and tar.download.zip, on posix.Screenshots (if appropriate):
Types of changes
Checklist:
🤖 drafted with Claude Code, reviewed before submitting.