Skip to content

test(apiArchiver): the single-resource archive is named after the resource#3080

Open
michaelstingl wants to merge 1 commit into
opencloud-eu:mainfrom
michaelstingl:issue-308-archive-filename
Open

test(apiArchiver): the single-resource archive is named after the resource#3080
michaelstingl wants to merge 1 commit into
opencloud-eu:mainfrom
michaelstingl:issue-308-archive-filename

Conversation

@michaelstingl

Copy link
Copy Markdown
Contributor

Description

Adds one scenario to tests/acceptance/features/apiArchiver/downloadById.feature: the archive of a single folder carries a Content-Disposition filename of the folder (for example my_data.zip), not the constant download.zip.

It reuses existing steps only: the archiver download step (which stores the response) and the generic the following headers should match these regular expressions assertion. No new step-def.

Related Issue

Enhancement tracked in reva:

The fix is reva:

Motivation and Context

A single-folder archive download was always named download.zip/download.tar until the handler resolved the resource name for the Content-Disposition header. The existing apiArchiver scenarios assert only the archive contents, never the filename, so this pins the naming at the product boundary.

How Has This Been Tested?

Locally, the feature against a running server, on two builds and both storages:

  • opencloud on the shipped reva (has the change): downloadById.feature passes on posix and decomposed (11/11), the new scenario green on zip and tar.
  • opencloud built on a reva with the change reverted: only the new scenario fails, the archive coming back as download.zip, on posix.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation added (n/a: tests-only, no changelog fragment)

🤖 drafted with Claude Code, reviewed before submitting.

…ource

An archive download of a single folder was always named "download.zip" until the
handler resolved the resource name for the Content-Disposition header
(opencloud-eu/reva#661). Add a scenario asserting the
archive of a folder carries a Content-Disposition filename of the folder,
reusing the archiver download step and the header-regex assertion.

Verified red->green on posix and decomposed: red on an opencloud built on a reva
with the change reverted (the archive is "download.zip"), green on the shipped
reva.
@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant