Skip to content

HYPERFLEET-1131 - ci: skip version bump check for non-contract PRs#55

Closed
kuudori wants to merge 1 commit into
openshift-hyperfleet:mainfrom
kuudori:HYPERFLEET-1131
Closed

HYPERFLEET-1131 - ci: skip version bump check for non-contract PRs#55
kuudori wants to merge 1 commit into
openshift-hyperfleet:mainfrom
kuudori:HYPERFLEET-1131

Conversation

@kuudori
Copy link
Copy Markdown
Contributor

@kuudori kuudori commented May 27, 2026

Only require version bump when .tsp files change. Docs, CI, and tooling PRs no longer trigger unnecessary releases.

Summary

  • HYPERFLEET-1131

Test Plan

  • Unit tests added/updated
  • make test-all passes
  • make lint passes
  • Helm chart changes validated with make test-helm (if applicable)
  • Deployed to a development cluster and verified (if Helm/config changes)
  • E2E tests passed (if cross-component or major changes)

Only require version bump when .tsp files change. Docs, CI, and
tooling PRs no longer trigger unnecessary releases.
@openshift-ci openshift-ci Bot requested review from crizzo71 and jsell-rh May 27, 2026 17:07
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 27, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mbrudnoy for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 509b6e8e-d4f8-4e23-8360-27e785a952dd

📥 Commits

Reviewing files that changed from the base of the PR and between 78199f6 and a5ad740.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated CI workflow Node.js version to 20.
    • Added contract-change detection to CI pipeline; version checks now conditionally execute based on contract modifications.

Walkthrough

This PR updates the CI workflow in .github/workflows/ci.yml with two changes. First, it adds a new "Check for contract changes" step that detects modifications to TypeSpec (*.tsp) contract files by comparing against the PR base, emitting a boolean output to gate downstream steps. The "Check version bump" step now runs conditionally only when contract files have changed. Second, the Node.js setup step is updated to specify the version using double-quoted string syntax ("20") instead of an unquoted value.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: adding conditional logic to skip version bump checks for PRs that don't modify .tsp contract files.
Description check ✅ Passed The description is directly related to the changeset, explaining the purpose of the CI workflow update and the problem it solves for non-contract PRs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.


Comment @coderabbitai help to get the list of available commands and usage tips.

@kuudori kuudori closed this May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant