Skip to content

[release-4.22] RFE-5434: Add cluster ID and timestamp to must-gather directory name#2290

Open
asadawar wants to merge 1 commit into
openshift:release-4.22from
asadawar:cherry-pick-4.22-must-gather
Open

[release-4.22] RFE-5434: Add cluster ID and timestamp to must-gather directory name#2290
asadawar wants to merge 1 commit into
openshift:release-4.22from
asadawar:cherry-pick-4.22-must-gather

Conversation

@asadawar

Copy link
Copy Markdown
Contributor

Cherry-pick of #2252 from main to release-4.22.

Adds cluster ID and timestamp to must-gather directory names so that multiple collections from the same or different clusters are distinguishable without manual renaming.

Before: must-gather.local.1234567890
After: must-gather_<cluster-id>_<YYYYMMDD-HHMMSS>

Original PR: #2252
RFE: https://issues.redhat.com/browse/RFE-5434
OCPSTRAT: https://redhat.atlassian.net/browse/OCPSTRAT-3252

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 17, 2026
@openshift-ci-robot

openshift-ci-robot commented Jun 17, 2026

Copy link
Copy Markdown

@asadawar: This pull request references RFE-5434 which is a valid jira issue.

Details

In response to this:

Cherry-pick of #2252 from main to release-4.22.

Adds cluster ID and timestamp to must-gather directory names so that multiple collections from the same or different clusters are distinguishable without manual renaming.

Before: must-gather.local.1234567890
After: must-gather_<cluster-id>_<YYYYMMDD-HHMMSS>

Original PR: #2252
RFE: https://issues.redhat.com/browse/RFE-5434
OCPSTRAT: https://redhat.atlassian.net/browse/OCPSTRAT-3252

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 23219496-39ca-4c8e-89e8-0e09265f16ce

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 17, 2026
@openshift-ci openshift-ci Bot requested review from adambkaplan and ardaguclu June 17, 2026 13:50
@openshift-ci

openshift-ci Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: asadawar
Once this PR has been reviewed and has the lgtm label, please assign ardaguclu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…directory name

Cherry-pick of openshift#2252 from main.

Assisted-by: Claude Code
@asadawar asadawar force-pushed the cherry-pick-4.22-must-gather branch from fcf51d3 to ac5f592 Compare June 17, 2026 13:52
@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 17, 2026
@openshift-ci

openshift-ci Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

@asadawar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-builds fcf51d3 link false /test e2e-aws-ovn-builds

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants