OCPBUGS-85828: Update catalogs for 4.23/5.0#734
Conversation
openshift-ci-robot
added
jira/severity-critical
|
@tmshort: This pull request references Jira Issue OCPBUGS-85828, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughUpgrades catalogd and ClusterCatalog image tags from v4.22 to v5.0, introduces a new catalog discovery helper that dynamically selects an installable OLMv1 GA package from serving ClusterCatalogs, updates the OLMv1 test to use the discovered package instead of hard-coded values, and adjusts test logging to stderr. ChangesCatalogd upgrade and test improvements
Sequence Diagram(s)sequenceDiagram
participant Test as OLMv1 Test
participant K8sAPI as Kubernetes API
participant Catalogd as catalogd Proxy
participant Scanner as scanPackages
Test->>K8sAPI: List ClusterCatalogs
K8sAPI-->>Test: catalog list
Test->>Test: filter TypeServing=True
Test->>Catalogd: GET /api/v1/all (with 404-retry)
Catalogd-->>Test: JSONL response
Test->>Scanner: feed JSONL
Scanner-->>Test: ranked or fallback package
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 14 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (14 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
openshift-ci-robot
added
jira/valid-bug
|
@tmshort: This pull request references Jira Issue OCPBUGS-85828, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
Bot
added
the
approved
tmshort
force-pushed
the
update-catalog-tag
branch
from
1441769 to
bd8cc25
Compare
|
@tmshort: This pull request references Jira Issue OCPBUGS-85828, which is valid. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
|
Hi @tmshort the default catalog tests uses the images from here so will fail see: |
I expected CI to fail (because those catalogs are not available yet), but did not consider the default-cartalog-consistency tests. Thanks. |
tmshort
force-pushed
the
update-catalog-tag
branch
from
bd8cc25 to
b3db3f1
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@openshift/default-catalog-consistency/test/validate/suite_test.go`:
- Around line 33-39: The suite setup currently uses fmt.Println in the var _ =
Describe initialization (see utils.ClusterCatalogVersion and the images loop)
which emits non-JSON stdout and leaks REGISTRY_AUTH_FILE; replace those
fmt.Println calls with GinkgoWriter (or fmt.Fprintln(os.Stderr, ...)) so output
goes to test logs/stderr instead of stdout, and remove or redact printing of the
REGISTRY_AUTH_FILE value (e.g., log that an auth file is configured without
printing the path). Ensure changes are applied where ClusterCatalogVersion() is
handled and in the second print near the REGISTRY_AUTH_FILE usage so no non-JSON
stdout is emitted during suite init.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 3b56e87e-9ee0-49e3-a5c1-a73d44857a2c
📒 Files selected for processing (5)
openshift/catalogd/manifests-experimental.yamlopenshift/catalogd/manifests.yamlopenshift/default-catalog-consistency/test/utils/utils.goopenshift/default-catalog-consistency/test/validate/suite_test.goopenshift/helm/catalogd.yaml
✅ Files skipped from review due to trivial changes (1)
- openshift/helm/catalogd.yaml
🚧 Files skipped from review as they are similar to previous changes (2)
- openshift/catalogd/manifests-experimental.yaml
- openshift/catalogd/manifests.yaml
tmshort
force-pushed
the
update-catalog-tag
branch
from
b3db3f1 to
6312355
Compare
|
/hold This is expected to fail until v4.23 and v5.0 catalogs are available. |
openshift-ci
Bot
added
the
do-not-merge/hold
tmshort
force-pushed
the
update-catalog-tag
branch
from
6312355 to
da150a1
Compare
|
Seems that |
|
/retest |
tmshort
force-pushed
the
update-catalog-tag
branch
2 times, most recently
from
a39b6ea to
d5a66d0
Compare
|
/retest |
openshift-ci
Bot
removed
the
do-not-merge/hold
|
/retest |
tmshort
force-pushed
the
update-catalog-tag
branch
from
55bc4b5 to
0a3fddb
Compare
tmshort
force-pushed
the
update-catalog-tag
branch
2 times, most recently
from
fe9b3e7 to
caab2a4
Compare
Set catalog image tags to v5.0 for the 4.23/5.0 release. Dynamically discover an installable package from the serving catalogs instead of hardcoding quay-operator v3.13.10, preferring quay-operator, cluster-logging, serverless-operator, logic-operator in that order then alling back to the first available package. Signed-off-by: Todd Short <tshort@redhat.com>
tmshort
force-pushed
the
update-catalog-tag
branch
from
caab2a4 to
4fe2e7d
Compare
|
/retest |
|
/test openshift-e2e-aws |
1 similar comment
|
/test openshift-e2e-aws |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ankitathomas, perdasilva, rashmigottipati, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@tmshort: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/verified by @Leo6Leo verification passed, spinned up the cluster with cluster-bot and the PR in it
|
|
@Leo6Leo: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
verified
|
@tmshort: Jira Issue Verification Checks: Jira Issue OCPBUGS-85828 Jira Issue OCPBUGS-85828 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
8 participants
Set catalog image tags to v5.0 for the 4.23/5.0 release.
Fixes: OCPBUGS-85828
Summary by CodeRabbit
Chores
Tests