CNTRLPLANE-3629: cluster-authentication-operator: add periodic TPNU job for external oidc tests#80618
Conversation
…idc tests Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
|
@everettraven: This pull request references CNTRLPLANE-3629 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
WalkthroughTwo new periodic e2e test entries — ChangesTechPreview Periodic Job Additions
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse |
|
@everettraven: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/lgtm |
|
/pj-rehearse ack /hold Holding in case you wanted someone else to approve. Feel free to unhold if I misunderstood :D . |
|
@ehearne-redhat: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
Not sure why tide says that this needs to be by authors /lgtm /hold cancel |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ehearne-redhat, everettraven, liouk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
It looks like there are several merge patterns but it does pass at least one. So it should be fine. :) |
|
Wonder if these required checks are stuck - trying to kick them again... /retest-required |
|
@everettraven: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
I noticed that we had removed all the TPNU jobs for the external oidc feature tests after promoting it to the default feature set.
As part of CNTRLPLANE-3629 we want to validate that promoting a new feature to TPNU, that builds on top of the base external oidc feature, does not introduce a regression as part of promoting it. Draft promotion PR: openshift/api#2893
To do that, this PR adds a couple AWS-based TPNU jobs that we can trigger for a rough assessment of this.
Summary by CodeRabbit
This PR re-adds periodic TPNU (Testing for Promotion to Next Update) test jobs for AWS-based external OIDC feature testing in the cluster-authentication-operator's CI configuration. Specifically, two new periodic test job definitions are added to the 5.0 release CI configuration:
TechPreviewNoUpgradefeature set enabledTechPreviewNoUpgradefeature set enabledBoth jobs mirror the structure and configuration of their non-TechPreview counterparts (which already exist in the file), including the same cluster profiles, test arguments, test suites, and workflow wiring. The key difference is the addition of
FEATURE_SET: TechPreviewNoUpgradein the environment configuration.This enables validation that a new feature building on top of the base external OIDC feature (as referenced in ticket CNTRLPLANE-3629) does not introduce regressions during its promotion through the feature set hierarchy.
Impact: OpenShift CI infrastructure – cluster-authentication-operator's release 5.0 periodic job definitions