[cifmw_block_device] Add thin-provisioned LV support for Ceph OSDs#3972
[cifmw_block_device] Add thin-provisioned LV support for Ceph OSDs#3972bogdando wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
tested this downstream for BM SNO DCN job. I will test this also with an hci uni job for regressions - together with #3773 |
|
Build failed (check pipeline). Post ❌ openstack-k8s-operators-content-provider FAILURE in 6m 33s |
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 29m 41s |
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 06m 20s |
bogdando
changed the title
Modify cifmw_block_device role to support loop back and thin LVM devices. For ceph deploy hook, when cifmw_ceph_thin_pool is defined, create thin LVs from an existing VG thin pool instead of loop-backed files. This supports baremetal hosts where the disk is fully consumed by a thin pool with no raw devices available for cephadm. The new play runs before the existing loop device play and sets cifmw_ceph_spec_data_devices with explicit LV paths, which also causes the loop device play to be skipped. Signed-off-by: Bohdan Dobrelia <bdobreli@redhat.com>
|
this worked on my test env. I will test this also with an hci uni job for regressions - together with #3773 |
DO you have a ink for those tests? |
fultonj
left a comment
fultonj
left a comment
There was a problem hiding this comment.
It is imperative that users be able to override cifmw_ceph_spec_data_devices and that they are free from it always being set as a fact.
and that is not broken by this patch. |
|
Let's make sure hci-crc and unijobs which use ceph (e.g. gamma or delta) pass before merging this. |
|
From my review, this should be fine. The code being change has a lot of operational years on it in different CI jobs including CRC and uni so let's make sure they don't break from it. Other than that it's fine by me. |
removed the label in favour of checking CRC jobs output |
|
we see that podified-multinode-hci-deployment-crc already passed. we just want to make sure we get a green uni job like gamma or delta |
|
downstream testproject passed tempest tests, the horizon test failures are unrelated |
3 participants
When cifmw_ceph_thin_pool is defined, create thin LVs from an existing VG thin pool instead of loop-backed files. This supports baremetal hosts where the disk is fully consumed by a thin pool with no raw devices available for cephadm.
The new play runs before the existing loop device play and sets cifmw_ceph_spec_data_devices with explicit LV paths, which also causes the loop device play to be skipped.
Related OSPRH-27841