-
Notifications
You must be signed in to change notification settings - Fork 14
Add RBAC roles for ESO #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
8 changes: 8 additions & 0 deletions
8
components/secrets/external-secrets-operator/redhat/external-secrets-namespace.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| --- | ||
| # Explicitly create the external-secrets namespace so the allow-vault-egress | ||
| # NetworkPolicy (wave 2) can always find it, regardless of ESO operator timing. | ||
| # The ESO operator will use this existing namespace when deploying its pods. | ||
| apiVersion: v1 | ||
| kind: Namespace | ||
| metadata: | ||
| name: external-secrets |
15 changes: 15 additions & 0 deletions
15
components/secrets/external-secrets-operator/redhat/externalsecretsconfig.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| --- | ||
| # ExternalSecretsConfig is required by the Red Hat External Secrets Operator (RHESO) | ||
| # to deploy the actual ESO controller pods (external-secrets, webhook, cert-controller). | ||
| # Sync wave 1 ensures this is applied AFTER the ESO operator Subscription (wave 0) | ||
| # is healthy and the operator.openshift.io CRD is available. | ||
| # SkipDryRunOnMissingResource bypasses ArgoCD's pre-sync CRD validation so wave 0 | ||
| # can install the ESO operator (and its CRD) before wave 1 applies this resource. | ||
| apiVersion: operator.openshift.io/v1alpha1 | ||
| kind: ExternalSecretsConfig | ||
| metadata: | ||
| name: cluster | ||
| annotations: | ||
| argocd.argoproj.io/sync-wave: "1" | ||
| argocd.argoproj.io/sync-options: SkipDryRunOnMissingResource=true | ||
| spec: {} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 changes: 28 additions & 0 deletions
28
components/secrets/external-secrets-operator/redhat/vault-egress-netpol.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| --- | ||
| # Allow ESO pods to reach Vault (vault.corp.redhat.com:8200). | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. publishing an internal name on public repository? |
||
| # The RHESO operator creates a deny-all-traffic NetworkPolicy by default, | ||
| # so egress to Vault must be explicitly permitted. | ||
| # Using corporate network CIDR (10.30.0.0/16) instead of specific IP | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. publishing internal range? |
||
| # to avoid breakage if Vault IP changes within the corp network. | ||
| # The external-secrets namespace is pre-created explicitly (external-secrets-namespace.yaml) | ||
| # so this NetworkPolicy can be applied in wave 1 without timing issues. | ||
| apiVersion: networking.k8s.io/v1 | ||
| kind: NetworkPolicy | ||
| metadata: | ||
| name: allow-vault-egress | ||
| namespace: external-secrets | ||
| annotations: | ||
| argocd.argoproj.io/sync-wave: "1" | ||
| spec: | ||
| podSelector: | ||
| matchLabels: | ||
| app.kubernetes.io/name: external-secrets | ||
| policyTypes: | ||
| - Egress | ||
| egress: | ||
| - to: | ||
| - ipBlock: | ||
| cidr: 10.30.0.0/16 | ||
| ports: | ||
| - protocol: TCP | ||
| port: 8200 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that should be added to the sync-wave component.