feat(argocd-sync): expected_revision rollout-confirm (app-agnostic deploy gate)#5
Merged
Merged
Conversation
…ploy gate) Optional expected_revision (or derived from gitops_repo branch HEAD via git ls-remote) so each app must have synced TO the new GitOps commit (prefix match) IN ADDITION to Synced+Healthy — a pre-existing Synced+Healthy on the OLD commit can no longer false-green a rollout. One repo HEAD covers a whole matrix of per-service commits. Back-compat: unset → Synced+Healthy only. This is the app-agnostic fallback in the v2.0 deploy gate (versionProbe → THIS → content-only). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
Under set -e a single 5xx/timeout from argocd-server (refresh or status fetch) aborted the whole job instead of retrying — defeating the wait loop. Refresh now '|| true'; a failed status fetch sleeps + continues the poll. Resilience the loop was meant to provide. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an app-agnostic rollout-confirm to
argocd-sync: optionalexpected_revision(or derived fromgitops_repobranch HEAD viagit ls-remote) so each app must have synced to the new GitOps commit (prefix match) in addition to Synced+Healthy.This is the middle tier of the v2.0 deploy gate precedence (versionProbe → ArgoCD rollout-confirm → content-only), for BYO apps that expose no version. Part of S4/S3 (with #2 #3 #4).
🤖 Generated with Claude Code