feat(kaniko): basic-auth registry push (private Harbor as nonprod registry)#6
Merged
Merged
Conversation
…istry) Add registry_username/password secrets + a basic-auth branch: when no Workload-Identity SA but a registry password is present, build a docker config (auths keyed by registry host) and mount it so kaniko can push to a private basic-auth registry (e.g. a Harbor robot). Mutually exclusive with the WI SA path; k3d insecure path unchanged. Completes the registry-flexibility set: build (this) + promote/bridge (crane #3) now both speak basic-auth, so nonprod=Harbor / prod=cloud works end-to-end. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lets the kaniko build push to a private basic-auth registry (e.g. a Harbor robot), not just WI cloud registries or insecure k3d.
registry_username/registry_passwordsecrets → a basic-auth branch builds a docker config (auths keyed by registry host) and mounts it.Closes the build-side gap for nonprod=Harbor / prod=cloud registries (promote/bridge across them already works via crane #3). Part of opsta-ai-pe v2.0.
🤖 Generated with Claude Code