feat: add tests for the search#73
Open
jvillafanez wants to merge 2 commits into
Open
Conversation
9 tasks
dj4oC
reviewed
Jul 7, 2026
dj4oC
left a comment
Contributor
There was a problem hiding this comment.
Adds two new k6 load-test scenarios (upload-search/default and upload-search/indexing) that upload a document per user and exercise oCIS full-text search, plus fixture data and docs.
Findings
- Correctness: no issues found — setup/teardown cleans up created users and folders, and
default.k6.tsexplicitly sleeps forSLEEP_TIMEbefore searching to avoid indexing-lag flakiness;indexing.k6.tsdocuments that it intentionally does not wait (only checks the response status code), so behavior matches its stated purpose. - Performance benchmark baseline: neither new scenario documents a baseline/reference number to compare future runs against — per this repo's convention for new benchmark scenarios, flagging so a baseline can be established before/after merge.
- Minor: both
default.k6.tsandindexing.k6.tsimportrandomBytes(fromk6/crypto) andPermission/ShareType(fromk6-tdk/values) without using them — dead imports, no functional impact.
Verdict
Commenting
🤖 Automated review by Claude Code
Generated by Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a simple load test for "upload and search".
The upload will be done to each user's account, and each user will search in his own account. This seems to be a realistic approach (each user searching his own files), and it will also generate additional data in the index (each file is technically different and will be indexed independently).
Note that the test will search content, so a search extractor (tika, for example) needs to be configured in the oCIS instance.