Skip to content

feat: add tests for the search#73

Open
jvillafanez wants to merge 2 commits into
mainfrom
search_load
Open

feat: add tests for the search#73
jvillafanez wants to merge 2 commits into
mainfrom
search_load

Conversation

@jvillafanez

Copy link
Copy Markdown
Member

Add a simple load test for "upload and search".

The upload will be done to each user's account, and each user will search in his own account. This seems to be a realistic approach (each user searching his own files), and it will also generate additional data in the index (each file is technically different and will be indexed independently).

Note that the test will search content, so a search extractor (tika, for example) needs to be configured in the oCIS instance.

@dj4oC dj4oC left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adds two new k6 load-test scenarios (upload-search/default and upload-search/indexing) that upload a document per user and exercise oCIS full-text search, plus fixture data and docs.

Findings

  • Correctness: no issues found — setup/teardown cleans up created users and folders, and default.k6.ts explicitly sleeps for SLEEP_TIME before searching to avoid indexing-lag flakiness; indexing.k6.ts documents that it intentionally does not wait (only checks the response status code), so behavior matches its stated purpose.
  • Performance benchmark baseline: neither new scenario documents a baseline/reference number to compare future runs against — per this repo's convention for new benchmark scenarios, flagging so a baseline can be established before/after merge.
  • Minor: both default.k6.ts and indexing.k6.ts import randomBytes (from k6/crypto) and Permission/ShareType (from k6-tdk/values) without using them — dead imports, no functional impact.

Verdict

Commenting

🤖 Automated review by Claude Code


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants