feat: Added restate docs#162
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| ### Traces (`restate-traces`) | ||
|
|
||
| Restate emits one trace per invocation. Spans cover the full invocation lifecycle: | ||
|
|
There was a problem hiding this comment.
since we guide to configures RESTATE_TRACING_ENDPOINT ... i think this section should describe the spans emitted by restate server tracing.
also the restate docs mention spans like ingress, invocation-start, invocation-attempt, and invocation-end, while things like ctx.run, calls and sleeps are recorded as events on the attempt span. https://docs.restate.dev/server/monitoring/tracing#understanding-traces
so if these current span names are from TS SDK/app-level instrumentation?
There was a problem hiding this comment.
Yeah this was added in my TS app. Have updated docs but let me know if you want me to run again for updated screenshots
There was a problem hiding this comment.
like if its not too much of a work then yes... so that i will have an updated one :)
|
|
||
| const provider = new LoggerProvider({ | ||
| resource: resourceFromAttributes({ [ATTR_SERVICE_NAME]: "restate-service" }), | ||
| processors: [new BatchLogRecordProcessor(exporter)], |
There was a problem hiding this comment.
here we are using new BatchLogRecordProcessor(exporter) It might not work depending on the package version that a user are onto...
but the current otel js logs exporter uses new BatchLogRecordProcessor({ exporter: logExporter })
- it also include severityText as well https://github.com/open-telemetry/opentelemetry-js/blob/main/experimental/packages/exporter-logs-otlp-http/README.md
so should we update this ?
There was a problem hiding this comment.
Added the severityText.
BatchLogRecordProcessor(exporter) stays as-is - v0.219.0 (latest stable) takes positional arg. The { exporter } object form is unreleased main-branch API, not applicable yet.
|
@praveen5959 the overall thing lgtm... however these are some points I wanted to ask for... if it works then maybe I should go on and make these changes and add the log and traces screenshot from the stagging. |
2 participants
No description provided.