Reduce chat composer rerenders during streaming#2888
Draft
cursor[bot] wants to merge 5 commits into
Draft
Conversation
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
ChatComposerinputs so streaming thread message updates do not pass the full changingactiveThreadobject into the memoized composer.artifacts/react-scan/before-chat-composer-rerender.webmartifacts/react-scan/after-chat-composer-rerender.webmWhy
React Doctor and manual hot-path review identified
ChatView/ChatComposeras a high-churn surface during streaming. React Scan confirmed the composer region was highlighted during assistant token updates even though the composer was idle. The after recording shows the streaming timeline still updates while the composer region is no longer highlighted.UI Changes
No intended visual UI changes. Included before/after React Scan screen recordings for the interaction/performance behavior.
Checklist
Verification:
bun fmtbun lint(0 errors, existing warnings)bun typecheckbunx react-doctor --json --full --no-score apps/webbunx react-doctor --json --diff main --no-score apps/webNote
Reduce
ChatComposerrerenders during streaming by stabilizing propsuseStableModelSelectionto return a referentially stableModelSelectionref that only updates when the value materially changes, preventing unnecessary rerenders.onSend,onInterrupt, and other handler callbacks inuseEventCallbackto give them stable identities across renders.ChatComposerprops to acceptactiveThreadProviderInstanceIddirectly instead of the fullThreadobject, reducing the surface area that triggers rerenders.EMPTY_*constants to avoid new object references on each render.Macroscope summarized de26297.