docs: add TypeScript React rewrite plan#131
Open
KagamiChan wants to merge 3 commits into
Open
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Adds an implementation-ready plan for rewriting the plugin UI/application layer to TypeScript + modern React while preserving the existing Poi plugin contract and behavioral parity requirements.
Changes:
- Added a detailed, phased rewrite plan covering architecture, dependency boundaries, build/package contracts, and parity/testing gates.
- Documented strict constraints for lib-battle adoption, host-boundary typing, and compatibility validation (fixtures, parity categories, acceptance gates).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Comment on lines
21
to
25
| node-version: '14.x' | ||
|
|
||
| - uses: actions/cache@v2 | ||
| - uses: actions/cache@v4 | ||
| with: | ||
| path: ~/.npm |
Comment on lines
+101
to
+105
| 'reselect', | ||
| 'styled-components', | ||
| ], | ||
| onlyBundle: [], | ||
| }, |
Comment on lines
+110
to
+111
| `fixedExtension: false` is required so CJS output is `index.js`/`index.d.ts` instead of `index.cjs`/`index.d.cts`. The compatibility and package smoke tests must assert exact emitted filenames. | ||
| Use `deps.onlyBundle` only as a whitelist for dependencies that are already being bundled. It does not force bundling. If a non-host runtime package from `node_modules` must be bundled, add it deliberately to `deps.alwaysBundle`, also include it in `deps.onlyBundle`, document why it cannot remain external, and update the package smoke test to assert the bundled dependency is expected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing