chore: tighten eslint rule overrides

[KagamiChan]

Summary

• enable @typescript-eslint/no-require-imports globally, with a narrow .cjs override
• remove stale test ESLint overrides for any, unsafe rules, and import extensions
• replace avoidable TypeScript require() calls with imports and move tsdown config to ESM .mjs
• tighten reporter test harness types so tests no longer need a broad no-explicit-any exemption

Validation

• pnpm run typecheck
• pnpm run lint
• pnpm run build
• pnpm run smoke
• pnpm run test:coverage

[Copilot]

Pull request overview

This PR tightens the project’s ESLint configuration (notably enabling @typescript-eslint/no-require-imports broadly with a narrow .cjs escape hatch) and removes now-unnecessary test/type rule overrides by updating configs and test utilities to avoid require()/any.

Changes:

• Convert tsdown config to ESM and remove require() usage while still injecting __REPORTER_VERSION__ from package.json.
• Tighten ESLint overrides by enabling @typescript-eslint/no-require-imports globally and removing stale test/vendor exemptions.
• Improve reporter test harness typing so tests no longer need broad any-related rule disables.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
tsdown.config.mjs	Migrates config to ESM and replaces require('./package.json') with an ESM-safe version read.
eslint.config.mjs	Enables @typescript-eslint/no-require-imports globally and narrows the disable to **/*.cjs; removes stale test/vendor overrides.
tests/reporters/base.test.ts	Replaces createRequire() JSON loading with a direct package.json import for the reporter User-Agent/version assertions.
tests/helpers/reporter-test-harness.ts	Replaces broad any typings with tighter unknown/helper types and improves reporter constructor typing for tests.
src/types/vendor.d.ts	Tightens the electron module declaration from any to unknown.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[github-actions]

No findings to report. The changes are internally consistent and all CI checks pass. The PR tightens types across the test harness (any → structured types like TestStore, LooseReporter, TestWindowShip), removes the now-unnecessary blanket ESLint overrides for test files, converts the tsdown config from CJS to ESM, and narrows the electron stub from any to unknown — each change is well-motivated by the rule tightening and carries no concrete correctness, security, or maintenance risk.

opencode session  |  github run

[github-actions]

After thorough analysis of all 16 changed files, I have no high-confidence findings to report.

The changes are internally consistent and well-scoped:

• tsdown.config.mjs: Correctly converts from CJS TypeScript to ESM JavaScript using readFileSync + new URL('./package.json', import.meta.url) instead of require(). The .mjs extension is already used elsewhere in this project (e.g., vitest.config.mjs).

• eslint.config.mjs: Enables no-require-imports globally with a narrow **/*.cjs override. Removes test-specific overrides that are no longer needed after the type improvements.

• reporter-test-harness.ts: Replaces any with structured types (TestStore, TestWindowShip, ReporterUnderTest, etc.). The processData member on the generalized ReporterUnderTest type is the same pattern as before — only NightBattleCIReporter uses it, and existing tests don't call it on other reporters.

• vendor.d.ts: Changes electron module from any to unknown — the bare electron module is not directly imported anywhere in src/, so this has no runtime impact.

• game-api.ts: Widens GameApiPostBody to include number, which is needed for the RemodelItemReporter (whose post body includes api_slot_id: string | number).

• Reporter classes: Adding implements Reporter is safe — TypeScript allows implementations to have fewer parameters than the interface, and the actual dispatch code at src/index.ts:52 always passes all 5 arguments.

All CI checks pass per the PR description. No correctness, security, performance, or maintenance risks identified.

opencode session  |  github run

[Copilot]

Pull request overview

Copilot reviewed 23 out of 24 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

src/reporters/create-item.ts:33

• GameApiPostBody now allows numeric values, but isCreateItemPostBody only accepts strings. If postBody values are numbers, this reporter will log "Invalid create item report data" and skip reporting even though parseInt/Number conversion would work.

export default class CreateItemReporter extends BaseReporter implements Reporter {
  handle(
    method: GameApiMethod,
    path: GameApiPath,
    body: GameApiResponseBody,

[github-actions]

I've performed an adversarial review of all 25 changed files in this PR. Here's my assessment:

No high-confidence findings to report.

The changes are internally consistent and well-scoped:

• GameApiPostBody widening (string | undefined → string | number | undefined) is backward-compatible. The updated type guards in create-item.ts and create-ship.ts now accept both typeof === 'string' and typeof === 'number', and parseInt → parseInt10 handles both correctly with explicit radix.

• ESLint overrides removal for tests is safe: the no-unsafe-* rules never applied to tests (they're from recommendedTypeChecked, which is scoped to src/**), and the no-explicit-any exemption is no longer needed after the harness type tightening.

• vendor.d.ts changing electron from any to unknown has zero runtime impact — the bare electron module is not imported anywhere in src/.

• tsdown.config.mjs ESM conversion correctly reads package.json via readFileSync + new URL('./package.json', import.meta.url) — a standard ESM pattern.

• Test updates are thorough — all handle() calls now pass the correct argument count, and the harness types (TestStore, TestWindowShip, etc.) correctly model the real runtime shapes.

The suppressed Copilot comments (claiming guards reject numeric values) do not match the final code — both isCreateItemPostBody and isCreateShipPostBody checks were updated to accept ['number', 'string'].

opencode session  |  github run

[Copilot]

Pull request overview

Copilot reviewed 24 out of 25 changed files in this pull request and generated no new comments.