Docs/adr-lpmstorage#9
Draft
VikiPeeva wants to merge 4 commits into
Draft
Conversation
Added reviewers section to the ADR document.
alkuzman
suggested changes
Jun 22, 2026
alkuzman
left a comment
alkuzman
left a comment
Collaborator
There was a problem hiding this comment.
I did not review the proposals (options) in detail. I will do that in another round of review.
| Superseded by: | ||
| --- | ||
|
|
||
| # ADR-0001: Data Storage Format |
Collaborator
There was a problem hiding this comment.
The title is imprecise. Storage format of what exactly?
|
|
||
| ## Context | ||
|
|
||
| We need to store _Local Process Models (LPMs) and their occurrence lists in an event log_. Event log sizes can vary, |
Collaborator
There was a problem hiding this comment.
Maybe you should answer the following questions first:
- Why not jus LPMs?
- why occurrences?
- why in an event log?
| - Query-based read/write | ||
|
|
||
| There also exist various ways one can align LPMs to an event log: | ||
| - The storage focuses on one variation |
Collaborator
There was a problem hiding this comment.
You use the word variation here without explaining what is it. The image is not enough to explain. Also, why having this constraint is important?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.