Skip to content

add setuptools files for example package mentioned in Issue 248#659

Open
sosey wants to merge 2 commits into
pyOpenSci:mainfrom
sosey:issue248
Open

add setuptools files for example package mentioned in Issue 248#659
sosey wants to merge 2 commits into
pyOpenSci:mainfrom
sosey:issue248

Conversation

@sosey
Copy link
Copy Markdown
Contributor

@sosey sosey commented May 18, 2026

This adds example package files for setuptools, as mentioned in #248.
The examplePy package builds and tests pass with pytest.

Copy link
Copy Markdown
Collaborator

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sosey for the contribution.

Tagging Leah for a final review 😄

@willingc willingc requested a review from lwasser May 20, 2026 18:41
@lwasser lwasser moved this to pyconus-2026 in pyOpenSci sprints 2023-2026 May 22, 2026
@lwasser
Copy link
Copy Markdown
Member

lwasser commented May 28, 2026

This looks great @sosey i'm going to see if @ucodery has time to review only because he started the package examples but if not I will review soon! Good to see you again at our sprints! i'm sorry we didn't' get to chat during the day.

@lwasser lwasser requested a review from ucodery May 28, 2026 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: pyconus-2026

Development

Successfully merging this pull request may close these issues.

3 participants