Skip to content

src/ tests/: make Document.save() save a pdf for all document types. #5035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
julian-smith-artifex-com merged 1 commit into from
Jun 25, 2026
+19 −1
Merged

src/ tests/: make Document.save() save a pdf for all document types. #5035

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6529,7 +6529,12 @@ def save(
if user_pw and len(user_pw) > 40 or owner_pw and len(owner_pw) > 40:
raise ValueError("password length must not exceed 40")

pdf = _as_pdf_document(self)
pdf = _as_pdf_document(self, required=False)
if not pdf:
pdf_bytes = self.convert_to_pdf()
pdf_document = open(stream=pdf_bytes, filetype='pdf')
pdf = _as_pdf_document(pdf_document)

opts = mupdf.PdfWriteOptions()
opts.do_incremental = incremental
opts.do_ascii = ascii
Expand Down
13 changes: 13 additions & 0 deletions tests/test_markdown_support.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import pymupdf
import os
import textwrap


def test_archive_markdown():
Expand Down Expand Up @@ -71,3 +72,15 @@ def test_markdown_style():
assert "Roman" in spans[0]["font"]
else:
assert "Roman" not in spans[0]["font"]

def test_markdown_save():
md = textwrap.dedent('''
# title

## section

text
''')
with pymupdf.open(stream=md.encode(), filetype='md') as document_md:
out_pdf = os.path.normpath(f'{__file__}/../../tests/test_markdown_save.pdf')
document_md.save(out_pdf)
Loading