gh-140715: Add %C format code support to strptime()#145955
Conversation
jyalim
requested review from
StanFromIreland,
abalkin and
pganssle
as code owners
| 'Op': mapping['p'], | ||
| 'W': mapping['U'].replace('U', 'W'), | ||
| }) | ||
| mapping['W'] = mapping['U'].replace('U', 'W') |
There was a problem hiding this comment.
I also brought this dictionary update into the update above it for greater stylistic consistency.
|
Tests and patchcheck re-verified before pushing merged main. Congrats on the promotion, @StanFromIreland! |
|
Lint is failing in the CI. And, to be honest I don’t really see any benefit in running patchcheck, I would recommend you run pre-commit (lint) instead. I hope to review in a few days. |
Co-authored-by: Stan Ulbrych <stan@python.org>
|
Thank you, @StanFromIreland, all requests were implemented! |
|
Keeping current with upstream. |
|
@StanFromIreland I think this is in a good place after the simplification from two months ago. |
Documentation build overview
131 files changed ·
|
|
Thank you, @StanFromIreland, that further strengthened the implementation. All changes have been made, as requested. |
2 participants
Incrementally builds C99+ datetime support with addition of
%C. Also adds tests (for%Cand for%ywith%C) and updates documentation.Continued effort from PR: #140647, #144819, #144896.
Documentation drops (0) footnote and notes that zero-padded century numbers are optional (for centuries 0 to 99).
Passed all tests.
Passed patchcheck.
Issue: #140715
str*timeto C11 format codes #140715📚 Documentation preview 📚: https://cpython-previews--145955.org.readthedocs.build/